mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] arm: Add both .lds files to CLEAN_FILES unconditionally
@ 2016-08-24  1:47 Andrey Smirnov
  2016-08-24 12:02 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2016-08-24  1:47 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

'clean' target is listed on 'no-dot-config-targets' list in main
Makefile so that conditional statement would yeild the same result
every time. Given how CLEAN_FILES are rm'ed with -f there should be no
harm in specifying them both unconditionally.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/Makefile | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 55f7248..96ec588 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -314,9 +314,5 @@ endif
 common- += $(patsubst %,arch/arm/boards/%/,$(board-))
 
 CLEAN_FILES += include/generated/mach-types.h barebox-flash-image
-
-ifeq ($(CONFIG_CPU_V8), y)
 CLEAN_FILES += arch/arm/lib64/barebox.lds
-else
 CLEAN_FILES += arch/arm/lib32/barebox.lds
-endif
-- 
2.5.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm: Add both .lds files to CLEAN_FILES unconditionally
  2016-08-24  1:47 [PATCH] arm: Add both .lds files to CLEAN_FILES unconditionally Andrey Smirnov
@ 2016-08-24 12:02 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2016-08-24 12:02 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Tue, Aug 23, 2016 at 06:47:02PM -0700, Andrey Smirnov wrote:
> 'clean' target is listed on 'no-dot-config-targets' list in main
> Makefile so that conditional statement would yeild the same result
> every time. Given how CLEAN_FILES are rm'ed with -f there should be no
> harm in specifying them both unconditionally.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/Makefile | 4 ----
>  1 file changed, 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 55f7248..96ec588 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -314,9 +314,5 @@ endif
>  common- += $(patsubst %,arch/arm/boards/%/,$(board-))
>  
>  CLEAN_FILES += include/generated/mach-types.h barebox-flash-image
> -
> -ifeq ($(CONFIG_CPU_V8), y)
>  CLEAN_FILES += arch/arm/lib64/barebox.lds
> -else
>  CLEAN_FILES += arch/arm/lib32/barebox.lds
> -endif
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-24 12:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-24  1:47 [PATCH] arm: Add both .lds files to CLEAN_FILES unconditionally Andrey Smirnov
2016-08-24 12:02 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox