mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] i2c-mux-pca954x: Add code to control reset line
Date: Thu, 17 Nov 2016 07:43:53 +0100	[thread overview]
Message-ID: <20161117064353.ss5hhus4krgkrdsr@pengutronix.de> (raw)
In-Reply-To: <1479221205-13573-1-git-send-email-andrew.smirnov@gmail.com>

On Tue, Nov 15, 2016 at 06:46:45AM -0800, Andrey Smirnov wrote:
> Most recent device tree binding for that mux support specifying a GPIO
> connected to a reset line of that chip. Add code to handle that binding
> in order to be able to use the chip on boards that leverage
> aforementioned functionality.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index baeae7b..0d5515b 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -45,6 +45,8 @@
>  #include <i2c/i2c-algo-bit.h>
>  #include <i2c/i2c-mux.h>
>  #include <init.h>
> +#include <gpio.h>
> +#include <of_gpio.h>
>  
>  #define PCA954X_MAX_NCHANS 8
>  
> @@ -179,6 +181,7 @@ static int pca954x_probe(struct device_d *dev)
>  	int num, force;
>  	struct pca954x *data;
>  	int ret = -ENODEV;
> +	int gpio;
>  
>  	data = kzalloc(sizeof(struct pca954x), GFP_KERNEL);
>  	if (!data) {
> @@ -188,6 +191,10 @@ static int pca954x_probe(struct device_d *dev)
>  
>  	i2c_set_clientdata(client, data);
>  
> +	gpio = of_get_named_gpio(dev->device_node, "reset-gpios", 0);
> +	if (gpio_is_valid(gpio))
> +		gpio_direction_output(gpio, 1);
> +
>  	/* Read the mux register at addr to verify
>  	 * that the mux is in fact present.
>  	 */
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2016-11-17  6:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 14:46 Andrey Smirnov
2016-11-17  6:43 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161117064353.ss5hhus4krgkrdsr@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox