[PATCH 1/3] input: Fix compiler warning

[PATCH 1/3] input: Fix compiler warning

[Sascha Hauer]

Fixes:

drivers/input/input.c:46:17: warning: passing argument 2 of '__set_bit' from incompatible pointer type [-Wincompatible-pointer-types]

idev->keys is an array, so we don't need to take the address of it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/input/input.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/input.c b/drivers/input/input.c
index 31a9c22..14e44d1 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -43,9 +43,9 @@ void input_report_key_event(struct input_device *idev, unsigned int code, int va
 		return;
 
 	if (value)
-		set_bit(code, &idev->keys);
+		set_bit(code, idev->keys);
 	else
-		clear_bit(code, &idev->keys);
+		clear_bit(code, idev->keys);
 
 	event.code = code;
 	event.value = value;
-- 
2.10.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/3] globalvar: Make locally used function static

[Sascha Hauer]

Fixes:

common/globalvar.c:382:5: warning: no previous prototype for 'globalvar_simple_set' [-Wmissing-prototypes]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/globalvar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/globalvar.c b/common/globalvar.c
index e75cac9..85d0795 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -379,7 +379,7 @@ void globalvar_set_match(const char *match, const char *val)
 	}
 }
 
-int globalvar_simple_set(struct device_d *dev, struct param_d *p, const char *val)
+static int globalvar_simple_set(struct device_d *dev, struct param_d *p, const char *val)
 {
 	struct device_d *rdev;
 	const char *pname;
-- 
2.10.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/3] lib/int_sqrt.c: Fix compiler warning

[Sascha Hauer]

include int_sqrt.h to have the prototype for the function defined in
this file.

Fixes:
lib/int_sqrt.c:25:15: warning: no previous prototype for 'int_sqrt' [-Wmissing-prototypes]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 lib/int_sqrt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/int_sqrt.c b/lib/int_sqrt.c
index 30ccafb..bf8b18f 100644
--- a/lib/int_sqrt.c
+++ b/lib/int_sqrt.c
@@ -15,6 +15,7 @@
  */
 
 #include <common.h>
+#include <int_sqrt.h>
 
 /**
  * int_sqrt - rough approximation to sqrt
-- 
2.10.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox