mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/2] spi: mvebu: add LSB support
Date: Thu,  8 Dec 2016 11:52:25 +0100	[thread overview]
Message-ID: <20161208105226.27858-1-u.kleine-koenig@pengutronix.de> (raw)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/spi/mvebu_spi.c | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/mvebu_spi.c b/drivers/spi/mvebu_spi.c
index 6921cb8cd7db..c5d8732e4f84 100644
--- a/drivers/spi/mvebu_spi.c
+++ b/drivers/spi/mvebu_spi.c
@@ -31,8 +31,13 @@
 #define  IF_READ_READY		BIT(1)
 #define  IF_CS_ENABLE		BIT(0)
 #define SPI_IF_CONFIG		0x04
+
+#define  IF_RXLSBF		BIT(14)
+#define  IF_TXLSBF		BIT(13)
+
 #define  IF_CLK_DIV(x)		((x) << 11)
 #define  IF_CLK_DIV_MASK	(0x7 << 11)
+
 #define  IF_FAST_READ		BIT(10)
 #define  IF_ADDRESS_LEN_4BYTE	(3 << 8)
 #define  IF_ADDRESS_LEN_3BYTE	(2 << 8)
@@ -192,6 +197,8 @@ static int dove_spi_set_baudrate(struct mvebu_spi *p, u32 speed)
 
 static int mvebu_spi_set_mode(struct mvebu_spi *p, u8 mode)
 {
+	u32 val;
+
 	/*
 	 * From public datasheets of Orion SoCs, it is unclear
 	 * if the SPI controller supports setting CPOL/CPHA.
@@ -202,12 +209,19 @@ static int mvebu_spi_set_mode(struct mvebu_spi *p, u8 mode)
 	 * other mode than SPI_MODE0.
 	 */
 
-	if ((mode & (SPI_CPOL|SPI_CPHA)) == SPI_MODE_0)
-		return 0;
+	if ((mode & (SPI_CPOL|SPI_CPHA)) != SPI_MODE_0) {
+		pr_err("%s: unsupported SPI mode %02x\n", __func__, mode);
+		return -EINVAL;
+	}
 
-	pr_err("%s: unsupported SPI mode %02x\n", __func__, mode);
+	val = readl(p->base + SPI_IF_CONFIG);
+	if (mode & SPI_LSB_FIRST)
+		val |= IF_RXLSBF | IF_TXLSBF;
+	else
+		val &= ~(IF_RXLSBF | IF_TXLSBF);
+	writel(val, p->base + SPI_IF_CONFIG);
 
-	return -EINVAL;
+	return 0;
 }
 
 static int mvebu_spi_setup(struct spi_device *spi)
@@ -293,6 +307,12 @@ static int mvebu_spi_transfer(struct spi_device *spi, struct spi_message *msg)
 	int ret;
 	struct mvebu_spi *priv = priv_from_spi_device(spi);
 
+	ret = mvebu_spi_set_mode(priv, spi->mode);
+	if (ret) {
+		dev_err(&spi->dev, "Failed to set mode (0x%x)\n", (unsigned)spi->mode);
+		return ret;
+	}
+
 	ret = mvebu_spi_set_cs(priv, spi->chip_select, spi->mode, true);
 	if (ret)
 		return ret;
-- 
2.10.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2016-12-08 10:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 10:52 Uwe Kleine-König [this message]
2016-12-08 10:52 ` [PATCH 2/2] spi: mvebu: improve error reporting Uwe Kleine-König
2016-12-12  5:45 ` [PATCH 1/2] spi: mvebu: add LSB support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208105226.27858-1-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox