From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] spi: mvebu: use wait_on_timeout instead of a loop with udelay.
Date: Mon, 12 Dec 2016 06:45:21 +0100 [thread overview]
Message-ID: <20161212054521.ndohkuminlx7a75u@pengutronix.de> (raw)
In-Reply-To: <20161208102050.7617-1-u.kleine-koenig@pengutronix.de>
On Thu, Dec 08, 2016 at 11:20:50AM +0100, Uwe Kleine-König wrote:
> This looks nicer and reduces the time to transfer 40 MB at 50 MHz from
> 203 seconds to 87 seconds.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Side note:
>
> When using
>
> while(!(readl(p->base + SPI_IF_CTRL) & IF_READ_READY))
> ;
> return 0;
>
> instead, the time goes down to 24 seconds.
Have you tried how many loop iterations it takes to complete? Maybe it's
worth it to try a few times and only after that start a real timeout
loop.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-12-12 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 10:20 Uwe Kleine-König
2016-12-12 5:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212054521.ndohkuminlx7a75u@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox