mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] ata: pata-imx: simplify assignment of device name
Date: Fri, 23 Dec 2016 10:50:46 +0100	[thread overview]
Message-ID: <20161223095046.xnvd2taafojhrjgd@pengutronix.de> (raw)
In-Reply-To: <20161223094549.3311-1-u.kleine-koenig@pengutronix.de>

Hello,

On Fri, Dec 23, 2016 at 10:45:49AM +0100, Uwe Kleine-König wrote:
>  	dev->detect = pata_imx_detect;

BTW, another thing I noticed while reading through this driver is:

pata_imx_detect is a wrapper around ata_port_detect. Later in
imx_pata_probe the function ide_port_register is called which also calls
ata_port_detect.

I don't have a machine handy where I could test, but I guess
pata_imx_detect could be dropped. (Or alternatively ide_port_register
could be reworked and all callers fixed to setup a detect call.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-12-23  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  9:45 Uwe Kleine-König
2016-12-23  9:50 ` Uwe Kleine-König [this message]
2017-01-09  8:53   ` Sascha Hauer
2017-01-11 16:06     ` Uwe Kleine-König
2017-01-09  8:43 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161223095046.xnvd2taafojhrjgd@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox