From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] USB: host: hub: increase delay after device removal
Date: Mon, 9 Jan 2017 09:38:55 +0100 [thread overview]
Message-ID: <20170109083855.f2vxmkmtlczdv62t@pengutronix.de> (raw)
In-Reply-To: <1482938984.1946.1.camel@googlemail.com>
Hi Christoph,
On Wed, Dec 28, 2016 at 04:29:44PM +0100, Christoph Fritz wrote:
> This patch increases delay time for slow hubs after device removal.
Could you spent a few words what happens without this patch, i.e. how
the symptons look and which hardware you observed that? Without this
information it will be very hard to ever change this line again.
Sascha
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
> drivers/usb/core/hub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index f44aea5..0854e3a 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -201,7 +201,7 @@ static void usb_hub_port_connect_change(struct usb_device *dev, int port)
> if (dev->children[port] && !(portstatus & USB_PORT_STAT_ENABLE))
> usb_remove_device(dev->children[port]);
>
> - mdelay(200);
> + mdelay(500);
>
> /* Reset the port */
> if (hub_port_reset(dev, port, &portstatus) < 0) {
> --
> 2.1.4
>
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-01-09 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 15:29 Christoph Fritz
2017-01-09 8:38 ` Sascha Hauer [this message]
2018-05-17 16:19 ` Christoph Fritz
2018-05-22 7:54 ` Sascha Hauer
2018-05-22 8:09 ` Christoph Fritz
2018-05-23 13:36 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109083855.f2vxmkmtlczdv62t@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=chf.fritz@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox