From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cQViI-0001xn-21 for barebox@lists.infradead.org; Mon, 09 Jan 2017 08:53:59 +0000 Date: Mon, 9 Jan 2017 09:53:36 +0100 From: Sascha Hauer Message-ID: <20170109085336.x47typrhxwajq3fg@pengutronix.de> References: <20161223094549.3311-1-u.kleine-koenig@pengutronix.de> <20161223095046.xnvd2taafojhrjgd@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161223095046.xnvd2taafojhrjgd@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ata: pata-imx: simplify assignment of device name To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: barebox@lists.infradead.org On Fri, Dec 23, 2016 at 10:50:46AM +0100, Uwe Kleine-K=F6nig wrote: > Hello, > = > On Fri, Dec 23, 2016 at 10:45:49AM +0100, Uwe Kleine-K=F6nig wrote: > > dev->detect =3D pata_imx_detect; > = > BTW, another thing I noticed while reading through this driver is: > = > pata_imx_detect is a wrapper around ata_port_detect. Later in > imx_pata_probe the function ide_port_register is called which also calls > ata_port_detect. > = > I don't have a machine handy where I could test, but I guess > pata_imx_detect could be dropped. (Or alternatively ide_port_register > could be reworked and all callers fixed to setup a detect call.) ide_port_register() has: ret =3D ata_port_register(&ide->port); if (!ret) ata_port_detect(&ide->port); The call to ata_port_detect() goes back to: commit 9c8f73ba86884026f4bbfc6f593d73741cfebcdc Author: Michel Stam Date: Mon Apr 7 12:01:21 2014 +0200 The hunk adding ata_port_detect() is wrong as it shortcircuits the optional detection mechanism. Sascha -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox