From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ata/ahci: simplify ahci_read_id
Date: Mon, 9 Jan 2017 11:31:58 +0100 [thread overview]
Message-ID: <20170109103158.aoo5pdwadl3ky7lm@pengutronix.de> (raw)
In-Reply-To: <20161217204644.4419-1-u.kleine-koenig@pengutronix.de>
On Sat, Dec 17, 2016 at 09:46:44PM +0100, Uwe Kleine-König wrote:
> This is a dummy commit log body because I consider the change to trivial
> to write something sensible.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied, thanks
Sascha
> drivers/ata/ahci.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index c31b337ba231..cea031af5a84 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -216,11 +216,7 @@ static int ahci_read_id(struct ata_port *ata, void *buf)
> fis[1] = 1 << 7; /* Command FIS. */
> fis[2] = ATA_CMD_ID_ATA; /* Command byte. */
>
> - ret = ahci_io(ahci, fis, sizeof(fis), buf, NULL, SECTOR_SIZE);
> - if (ret)
> - return ret;
> -
> - return ret;
> + return ahci_io(ahci, fis, sizeof(fis), buf, NULL, SECTOR_SIZE);
> }
>
> static int ahci_rw(struct ata_port *ata, void *rbuf, const void *wbuf,
> --
> 2.10.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-01-09 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 20:46 Uwe Kleine-König
2016-12-19 20:39 ` [PATCH] fixup! " Uwe Kleine-König
2017-01-09 10:31 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109103158.aoo5pdwadl3ky7lm@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox