From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: barebox@lists.infradead.org
Subject: Re: Problem loading environment from spi-nor flash partition since barebox 2017.01.0
Date: Wed, 11 Jan 2017 09:32:54 +0100 [thread overview]
Message-ID: <20170111083254.hndsbxkeh7c5x3gt@pengutronix.de> (raw)
In-Reply-To: <12b302f6-75ae-bf83-370b-abaf0aef9d29@mev.co.uk>
On Tue, Jan 10, 2017 at 04:01:40PM +0000, Ian Abbott wrote:
> Hi!
>
> I thought I'd try updating my custom SoCFPGA-based board from barebox
> 2016.11.0 to 2017.01.0, and have only run into one problem, which is that it
> is no longer loading the barebox environment during boot:
>
> &qspi {
> status = "okay";
>
> flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "n25q00";
> reg = <0>;
> spi-max-frequency = <100000000>;
> m25p,fast-read;
> cdns,page-size = <256>;
> cdns,block-size = <16>;
> cdns,read-delay = <4>;
> cdns,tshsl-ns = <50>;
> cdns,tsd2d-ns = <50>;
> cdns,tchsh-ns = <4>;
> cdns,tslch-ns = <4>;
The problem is that your environment path points to the flash node which
does not have a driver as the corresponding device is not registered
properly.
With (real) SPI this is a little different and works as expected: If the
qspi node would be handled by the SPI layer then the SPI core would
register the child nodes as devices on a SPI bus. The normal probe
mechanism would then bind the device and the driver together.
With the cadence-quadspi driver a device is registered in
cqspi_setup_flash(), but there is never a driver attached to it, thus
the dev->driver test fails.
The proper way if probably to register the n25q00 device on a qspi bus
and to provide a qspi-nor-flash driver which gets probed then.
The not-so-proper, faster way could be to just create a dummy driver
struct and attach it to the device allocated in cqspi_setup_flash().
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-01-11 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 16:01 Ian Abbott
2017-01-10 19:42 ` Trent Piepho
2017-01-11 11:37 ` Ian Abbott
2017-01-11 8:32 ` Sascha Hauer [this message]
2017-01-11 13:02 ` Ian Abbott
2017-01-13 17:46 ` Trent Piepho
2017-01-16 7:13 ` s.hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111083254.hndsbxkeh7c5x3gt@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=abbotti@mev.co.uk \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox