mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR
@ 2017-01-16 10:45 Lucas Stach
  2017-01-16 10:45 ` [PATCH 2/3] usb: gadget: disable AT91 driver on SAMA5D4 Lucas Stach
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Lucas Stach @ 2017-01-16 10:45 UTC (permalink / raw)
  To: barebox

To satisfy the direct dependencies of the selected commands.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/Kconfig b/common/Kconfig
index 74e973999a3a..2383b772f8c5 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -856,6 +856,8 @@ config DEFAULT_ENVIRONMENT_GENERIC
 	depends on DEFAULT_ENVIRONMENT
 	depends on !DEFAULT_ENVIRONMENT_GENERIC_NEW
 	depends on SHELL_HUSH
+	select COMMAND_SUPPORT
+	select GLOBALVAR
 	select CMD_GETOPT
 	select CMD_CRC
 	select CMD_CRC_CMP
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] usb: gadget: disable AT91 driver on SAMA5D4
  2017-01-16 10:45 [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Lucas Stach
@ 2017-01-16 10:45 ` Lucas Stach
  2017-01-16 10:45 ` [PATCH 3/3] barebox-imd: add dependency on generated/compile.h also for PBL version Lucas Stach
  2017-01-17  6:58 ` [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2017-01-16 10:45 UTC (permalink / raw)
  To: barebox

This architecture is missing the right defines for the system
peripherals, that are needed for this driver to build successfully.

Disable it for now until someone with a clue about this architecture
can fill in the gap.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/usb/gadget/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 81c372320008..eb279ae8df4f 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -19,6 +19,7 @@ config USB_GADGET_DRIVER_AT91
 	bool
 	prompt "at91 gadget driver"
 	depends on ARCH_AT91
+	depends on !ARCH_SAMA5D4
 	default y
 	select USB_GADGET_DUALSPEED
 
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] barebox-imd: add dependency on generated/compile.h also for PBL version
  2017-01-16 10:45 [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Lucas Stach
  2017-01-16 10:45 ` [PATCH 2/3] usb: gadget: disable AT91 driver on SAMA5D4 Lucas Stach
@ 2017-01-16 10:45 ` Lucas Stach
  2017-01-17  6:58 ` [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2017-01-16 10:45 UTC (permalink / raw)
  To: barebox

Barebox-imd is also used in the PBL. As the object file names are different
for the PBL, the explicit dependency on generated/compile.h wasn't there.
This leads to random build failures in parallel builds, or worse the PBL
picking up the old compile.h defines from an earlier build.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/Makefile b/common/Makefile
index a36ae5e91f28..869b15a92a9f 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -86,6 +86,7 @@ endif
 # dependencies on generated files need to be listed explicitly
 $(obj)/version.o: include/generated/compile.h
 $(obj)/imd-barebox.o: include/generated/compile.h
+$(obj)/pbl-imd-barebox.o: include/generated/compile.h
 
 # compile.h changes depending on hostname, generation number, etc,
 # so we regenerate it always.
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR
  2017-01-16 10:45 [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Lucas Stach
  2017-01-16 10:45 ` [PATCH 2/3] usb: gadget: disable AT91 driver on SAMA5D4 Lucas Stach
  2017-01-16 10:45 ` [PATCH 3/3] barebox-imd: add dependency on generated/compile.h also for PBL version Lucas Stach
@ 2017-01-17  6:58 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2017-01-17  6:58 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Mon, Jan 16, 2017 at 11:45:44AM +0100, Lucas Stach wrote:
> To satisfy the direct dependencies of the selected commands.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  common/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 74e973999a3a..2383b772f8c5 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -856,6 +856,8 @@ config DEFAULT_ENVIRONMENT_GENERIC
>  	depends on DEFAULT_ENVIRONMENT
>  	depends on !DEFAULT_ENVIRONMENT_GENERIC_NEW
>  	depends on SHELL_HUSH
> +	select COMMAND_SUPPORT
> +	select GLOBALVAR
>  	select CMD_GETOPT
>  	select CMD_CRC
>  	select CMD_CRC_CMP
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-17  6:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16 10:45 [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Lucas Stach
2017-01-16 10:45 ` [PATCH 2/3] usb: gadget: disable AT91 driver on SAMA5D4 Lucas Stach
2017-01-16 10:45 ` [PATCH 3/3] barebox-imd: add dependency on generated/compile.h also for PBL version Lucas Stach
2017-01-17  6:58 ` [PATCH 1/3] defaultenv: select COMMAND_SUPPORT and GLOBALVAR Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox