From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] i.MX: vf610: Add support for ZII VF610 Dev Family
Date: Tue, 24 Jan 2017 09:09:43 +0100 [thread overview]
Message-ID: <20170124080943.mkjwtzpsoghg57ns@pengutronix.de> (raw)
In-Reply-To: <20170123055735.1277-1-andrew.smirnov@gmail.com>
Hi Andrey,
On Sun, Jan 22, 2017 at 09:57:34PM -0800, Andrey Smirnov wrote:
> Add support for ZII VF610 Dev based designs such as:
>
> - VF610 Dev, revision B
> - VF610 Dev, revision C
> - CFU1, revision A
> - SPU3, revision A
> - SCU4 AIB, revision C
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>
> Sascha, this patch is rebased on 'next' instead of 'master' so that
> you won't have to resolve conflicts with RDU2 patches in 'next'. Let
> me know if you'd rather have it rebased on 'master'.
It's fine to base on next in this case.
> +struct named_signal {
> + unsigned int gpio;
> + const char *name;
> + int value;
> +};
> +
> +static int expose_signals(const struct named_signal *signals,
> + size_t signal_num)
> +{
> + int ret, i;
> +
> + for (i = 0; i < signal_num; i++) {
> + const struct named_signal *signal = &signals[i];
> +
> + if (signal->value < 0)
> + ret = gpio_direction_input(signal->gpio);
> + else
> + ret = gpio_direction_output(signal->gpio, signal->value);
> +
> + if (ret) {
> + pr_err("Failed to configure \"%s\"\n", signal->name);
> + return ret;
> + }
This looks like gpio_request_array(). Could you use this instead?
> index 0000000..4465632
> --- /dev/null
> +++ b/arch/arm/boards/zii-vf610-dev/lowlevel.c
> @@ -0,0 +1,132 @@
> +#include <common.h>
> +#include <linux/sizes.h>
> +#include <mach/generic.h>
> +#include <asm/barebox-arm-head.h>
> +#include <asm/barebox-arm.h>
> +#include <mach/vf610-regs.h>
> +#include <mach/clock-vf610.h>
> +#include <mach/iomux-vf610.h>
> +#include <debug_ll.h>
> +
> +#if defined(CONFIG_DEBUG_LL)
> +# if !defined(CONFIG_DEBUG_VF610_UART)
> +# warning "CONFIG_DEBUG_LL is enabled but CONFIG_DEBUG_VF610_UART is not"
> +# else
> +# if CONFIG_DEBUG_IMX_UART_PORT != 1
> +# warning "CONFIG_DEBUG_LL output is not drirected to port 1"
> +# endif
> +# endif
> +#endif
Just because this board is enabled doesn't mean the user is actually
currently interested in this board. He might want to enable
CONFIG_DEBUG_LL for another board, still he is warned about an invalid
config here. This is not good.
You could drop the DEBUG_LL support and instead go to PBL console
support. See arch/arm/boards/freescale-mx6-sabrelite/lowlevel.c
for a good example. Basically it means you call this right after entry:
arm_early_mmu_cache_invalidate();
relocate_to_current_adr();
setup_c();
barrier();
From here on you have a valid C environment (And thus don't need to work
around switch/case with wrong LUTs) and can also call:
pbl_set_putc(xxx_uart_putc, uart);
after that you can use printf like functions to print messages.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-01-24 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 5:57 Andrey Smirnov
2017-01-23 5:57 ` [PATCH] spi: i.MX: Add driver for DSPI Andrey Smirnov
2017-01-24 8:26 ` Sascha Hauer
2017-01-26 22:24 ` Andrey Smirnov
2017-01-24 8:09 ` Sascha Hauer [this message]
2017-01-26 22:38 ` [PATCH] i.MX: vf610: Add support for ZII VF610 Dev Family Andrey Smirnov
2017-01-30 7:05 ` Sascha Hauer
2017-02-03 15:27 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124080943.mkjwtzpsoghg57ns@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox