mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Falco Hyfing <hyfinglists@gmail.com>,
	barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] lib: xz: add support for bcj filters
Date: Wed, 22 Feb 2017 11:21:49 +0100	[thread overview]
Message-ID: <20170222102149.anazwahf4adk2zai@pengutronix.de> (raw)
In-Reply-To: <CAGm1_ktrPpdx3_OGqHfdD2mwCaf9_d=V3y4xXJhX6NYpz5YkEA@mail.gmail.com>

On Wed, Feb 22, 2017 at 11:10:36AM +0100, Yegor Yefremov wrote:
> On Wed, Feb 22, 2017 at 11:03 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Wed, Feb 22, 2017 at 09:15:36AM +0100, Yegor Yefremov wrote:
> >> On Wed, Feb 22, 2017 at 5:29 AM, Jean-Christophe PLAGNIOL-VILLARD
> >> <plagnioj@jcrosoft.com> wrote:
> >> >
> >> >> On Feb 21, 2017, at 10:47 PM, yegorslists@googlemail.com wrote:
> >> >>
> >> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >> >>
> >> >> Add missing configuration options for various bcj filters. Without
> >> >> these options the lib/xz/xz_dec_bcj.c file will be compiled, but all
> >> >> filters will be disabled.
> >> >>
> >> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> >> >> ---
> >> >> lib/Kconfig | 28 ++++++++++++++++++++++++++++
> >> >> 1 file changed, 28 insertions(+)
> >> >>
> >> >> diff --git a/lib/Kconfig b/lib/Kconfig
> >> >> index f9f25bdef..83dd8e0a4 100644
> >> >> --- a/lib/Kconfig
> >> >> +++ b/lib/Kconfig
> >> >> @@ -22,6 +22,34 @@ config XZ_DECOMPRESS
> >> >>       bool "include xz uncompression support"
> >> >>       select UNCOMPRESS
> >> >>
> >> >> +if XZ_DECOMPRESS
> >> >> +
> >> >> +config XZ_DEC_X86
> >> >> +        bool "x86 BCJ filter decoder"
> >> >> +        default y
> >> > this need to be ARCH dependant
> >>
> >> Why? In Linux kernel it is not arch dependent, because AFAIK it
> >> describes only compression particularities. This way you can extract
> >> sqaushfs images on your ARM machine, that were compressed on SPARK
> >> etc.
> >
> > So xz uses the Sparc bcj filter even when compressing ARM binaries? That
> > doesn't sound very mature to me.
> 
> This is just an xz command line option. So it is completely in the
> user responsibility.

I see. What's the default for this option? The architecture xz is
running on?

Otherwise we could do a:

config XZ_DEC_ARM
        bool "ARM BCJ filter decoder"
        default y if ARCH_ARM

On the other hand I'm not sure if the potential image size gain for
disabling the unused bcj filters is even worth thinking about the
problem...

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-02-22 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 14:47 yegorslists
2017-02-22  4:29 ` Jean-Christophe PLAGNIOL-VILLARD
2017-02-22  8:15   ` Yegor Yefremov
2017-02-22 10:03     ` Sascha Hauer
2017-02-22 10:10       ` Yegor Yefremov
2017-02-22 10:21         ` Sascha Hauer [this message]
2017-02-22 10:35           ` Yegor Yefremov
2017-02-22 11:34             ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170222102149.anazwahf4adk2zai@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=hyfinglists@gmail.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox