mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] lseek: ensure errno is set on failure and return -1
Date: Fri, 24 Feb 2017 08:45:13 +0100	[thread overview]
Message-ID: <20170224074513.pxsqbvjd4uyuqndj@pengutronix.de> (raw)
In-Reply-To: <20170223212841.12846-1-u.kleine-koenig@pengutronix.de>

On Thu, Feb 23, 2017 at 10:28:41PM +0100, Uwe Kleine-König wrote:
> All error paths before calling the driver's lseek callback return -1 and
> set errno. Do the same if the callback returns an error.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  fs/fs.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/fs.c b/fs/fs.c
> index 2b4659cfbb76..e7b696591433 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -926,7 +926,13 @@ loff_t lseek(int fildes, loff_t offset, int whence)
>  		goto out;
>  	}
>  
> -	return fsdrv->lseek(&f->fsdev->dev, f, pos);
> +	pos = fsdrv->lseek(&f->fsdev->dev, f, pos);
> +	if (pos < 0) {
> +		errno = -pos;
> +		return -1;
> +	}

Before calling into the drivers lseek checks if the position is within
the bounds of the file. So when fsdrv->lseek() returns successfully then
the position must be the same that was passed in. I think we can just
let fsdrv->lseek() return an error code rather than the file position.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-02-24  7:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 21:28 Uwe Kleine-König
2017-02-24  7:45 ` Sascha Hauer [this message]
2017-02-25 20:14   ` Uwe Kleine-König
2017-03-02  7:39     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224074513.pxsqbvjd4uyuqndj@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox