[PATCH] nand-bb: fix writing to the end of a .bb device

[PATCH] nand-bb: fix writing to the end of a .bb device

[Uwe Kleine-König]

As nand_bb_write_buf calls mtd_write(bb->mtd, cur_ofs, now, ...) the
limit that now should be checked against is bb->mtd->size - cur_ofs.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/mtd/nand/nand-bb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/nand-bb.c b/drivers/mtd/nand/nand-bb.c
index 015f8dc524f3..a1523c3c8992 100644
--- a/drivers/mtd/nand/nand-bb.c
+++ b/drivers/mtd/nand/nand-bb.c
@@ -99,7 +99,7 @@ static int nand_bb_write_buf(struct nand_bb *bb, size_t count)
 	loff_t cur_ofs = bb->offset & ~(BB_WRITEBUF_SIZE - 1);
 
 	while (count) {
-		loff_t max = bb->mtd->size - bb->offset;
+		loff_t max = bb->mtd->size - cur_ofs;
 
 		if (max <= 0)
 			return -ENOSPC;
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] nand-bb: fix writing to the end of a .bb device

[Sascha Hauer]

On Wed, Mar 01, 2017 at 04:57:03PM +0100, Uwe Kleine-König wrote:
> As nand_bb_write_buf calls mtd_write(bb->mtd, cur_ofs, now, ...) the
> limit that now should be checked against is bb->mtd->size - cur_ofs.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mtd/nand/nand-bb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mtd/nand/nand-bb.c b/drivers/mtd/nand/nand-bb.c
> index 015f8dc524f3..a1523c3c8992 100644
> --- a/drivers/mtd/nand/nand-bb.c
> +++ b/drivers/mtd/nand/nand-bb.c
> @@ -99,7 +99,7 @@ static int nand_bb_write_buf(struct nand_bb *bb, size_t count)
>  	loff_t cur_ofs = bb->offset & ~(BB_WRITEBUF_SIZE - 1);
>  
>  	while (count) {
> -		loff_t max = bb->mtd->size - bb->offset;
> +		loff_t max = bb->mtd->size - cur_ofs;
>  
>  		if (max <= 0)
>  			return -ENOSPC;
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox