* [PATCH] lseek: tighten error checking and allow negative offsets for SEEK_END
@ 2017-03-02 14:37 Uwe Kleine-König
2017-03-03 6:08 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2017-03-02 14:37 UTC (permalink / raw)
To: barebox
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
fs/fs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c
index e7b696591433..1901c94ad1ea 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -910,6 +910,8 @@ loff_t lseek(int fildes, loff_t offset, int whence)
case SEEK_SET:
if (f->size != FILE_SIZE_STREAM && offset > f->size)
goto out;
+ if (offset < 0)
+ goto out;
pos = offset;
break;
case SEEK_CUR:
@@ -918,9 +920,9 @@ loff_t lseek(int fildes, loff_t offset, int whence)
pos = f->pos + offset;
break;
case SEEK_END:
- if (offset)
+ if (offset > 0)
goto out;
- pos = f->size;
+ pos = f->size + offset;
break;
default:
goto out;
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lseek: tighten error checking and allow negative offsets for SEEK_END
2017-03-02 14:37 [PATCH] lseek: tighten error checking and allow negative offsets for SEEK_END Uwe Kleine-König
@ 2017-03-03 6:08 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-03-03 6:08 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: barebox
On Thu, Mar 02, 2017 at 03:37:03PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> fs/fs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/fs/fs.c b/fs/fs.c
> index e7b696591433..1901c94ad1ea 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -910,6 +910,8 @@ loff_t lseek(int fildes, loff_t offset, int whence)
> case SEEK_SET:
> if (f->size != FILE_SIZE_STREAM && offset > f->size)
> goto out;
> + if (offset < 0)
> + goto out;
> pos = offset;
> break;
> case SEEK_CUR:
> @@ -918,9 +920,9 @@ loff_t lseek(int fildes, loff_t offset, int whence)
> pos = f->pos + offset;
> break;
> case SEEK_END:
> - if (offset)
> + if (offset > 0)
> goto out;
> - pos = f->size;
> + pos = f->size + offset;
> break;
> default:
> goto out;
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-03 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 14:37 [PATCH] lseek: tighten error checking and allow negative offsets for SEEK_END Uwe Kleine-König
2017-03-03 6:08 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox