mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] tftp: implement forward seeking
Date: Thu,  2 Mar 2017 16:55:28 +0100	[thread overview]
Message-ID: <20170302155528.20781-1-u.kleine-koenig@pengutronix.de> (raw)

Just abuse tftp_read to step forward.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 fs/tftp.c | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/fs/tftp.c b/fs/tftp.c
index 56d4365d773a..272a7106eb51 100644
--- a/fs/tftp.c
+++ b/fs/tftp.c
@@ -591,8 +591,29 @@ static int tftp_read(struct device_d *dev, FILE *f, void *buf, size_t insize)
 
 static loff_t tftp_lseek(struct device_d *dev, FILE *f, loff_t pos)
 {
-	/* not implemented in tftp protocol */
-	return -ENOSYS;
+	if (pos >= f->pos) {
+		char buf[1024];
+		int ret;
+		while (pos > f->pos) {
+			size_t len = min(sizeof(buf), (size_t)(pos - f->pos));
+			ret = tftp_read(dev, f, buf, len);
+
+			if (ret < 0)
+				return ret;
+			else if (!ret)
+				return -EINVAL;
+			f->pos += ret;
+
+			memory_display(buf, f->pos - len, 0x10, 4, 0);
+		}
+		return pos;
+	} else {
+		/*
+		 * We cannot seek backwards without reloading or caching the
+		 * file
+		 */
+		return -ENOSYS;
+	}
 }
 
 static DIR* tftp_opendir(struct device_d *dev, const char *pathname)
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2017-03-02 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 15:55 Uwe Kleine-König [this message]
2017-03-03  6:13 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302155528.20781-1-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox