From: Michael Olbrich <m.olbrich@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] video: add EFI Graphics Output Protocol support
Date: Thu, 9 Mar 2017 09:46:31 +0100 [thread overview]
Message-ID: <20170309084631.bkla463pgm5clgwv@pengutronix.de> (raw)
In-Reply-To: <1488776651-7555-1-git-send-email-plagnioj@jcrosoft.com>
On Mon, Mar 06, 2017 at 06:04:10AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/video/Kconfig | 4 +
> drivers/video/Makefile | 2 +
> drivers/video/efi_gop.c | 267 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 273 insertions(+)
> create mode 100644 drivers/video/efi_gop.c
>
[...]
> diff --git a/drivers/video/efi_gop.c b/drivers/video/efi_gop.c
> new file mode 100644
> index 000000000..ccb4af3d9
[...]
> +static struct fb_ops efi_gop_ops = {
> + .fb_activate_var = efi_gop_fb_activate_var,
> +};
This is missing the fb_enable/fb_disable callbacks. Both are not optional.
The framebuffer console is broken without this.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-03-09 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 5:02 [PATCH 0/2] add support of efi Serial IO and Graphics Output Protocol Jean-Christophe PLAGNIOL-VILLARD
2017-03-06 5:04 ` [PATCH 1/2] video: add EFI Graphics Output Protocol support Jean-Christophe PLAGNIOL-VILLARD
2017-03-06 5:04 ` [PATCH 2/2] efi: add serial driver support Jean-Christophe PLAGNIOL-VILLARD
2017-03-06 9:34 ` [PATCH 2/2 v2] " Jean-Christophe PLAGNIOL-VILLARD
2017-03-07 7:01 ` Sascha Hauer
2017-03-11 16:23 ` Michael Olbrich
2017-03-12 12:07 ` Jean-Christophe PLAGNIOL-VILLARD
2017-03-09 8:46 ` Michael Olbrich [this message]
2017-03-09 8:49 ` [PATCH 1/2] video: add EFI Graphics Output Protocol support Jean-Christophe PLAGNIOL-VILLARD
2017-03-06 8:18 ` [PATCH 0/2] add support of efi Serial IO and Graphics Output Protocol Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309084631.bkla463pgm5clgwv@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox