From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mo179.mail-out.ovh.net ([178.32.228.179]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cmLSp-0004Mt-Rl for barebox@lists.infradead.org; Fri, 10 Mar 2017 14:24:19 +0000 Received: from player716.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 4E207303D2 for ; Fri, 10 Mar 2017 15:23:52 +0100 (CET) Date: Fri, 10 Mar 2017 15:30:09 +0100 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20170310143009.GD19458@mail.ovh.net> References: <1489055471-12836-1-git-send-email-plagnioj@jcrosoft.com> <1489055471-12836-3-git-send-email-plagnioj@jcrosoft.com> <20170310070043.qsu5mcr2fmnn3oxi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170310070043.qsu5mcr2fmnn3oxi@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] fbcon: use __iowrite{32/64} to speedup the framebuffer console scrolling To: Sascha Hauer Cc: barebox@lists.infradead.org On 08:00 Fri 10 Mar , Sascha Hauer wrote: > On Thu, Mar 09, 2017 at 11:31:11AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > this devide the time by 4 on x86 > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > drivers/video/fbconsole.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbconsole.c b/drivers/video/fbconsole.c > > index b261f1704..b5e951e23 100644 > > --- a/drivers/video/fbconsole.c > > +++ b/drivers/video/fbconsole.c > > @@ -6,6 +6,7 @@ > > #include > > #include > > #include > > +#include > > > > enum state_t { > > LIT, /* Literal input */ > > @@ -202,7 +203,7 @@ static void printchar(struct fbc_priv *priv, int c) > > > > buf = gui_screen_render_buffer(priv->sc); > > > > - memcpy(buf, buf + line_height, line_height * priv->rows); > > + __iowrite64_copy(buf, buf + line_height, (line_height * priv->rows) >> 2); > > Shouldn't this be >> 3? > > Besides, I'm not sure using __iowrite64_copy is the right weapon here. > Maybe better port arch/x86/lib/memcpy_64.S to get an optimized memcpy? My other issue to the current driver is so so slow Normaly we need to have a shadow buffer with twice the size of the real buffer And we should use a timer when we have to blit too much and add scroll support I've those feature on an other barebox fbcon implementation Best Regards, J. > > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox