From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] fix: console: expose consoles in devfs
Date: Mon, 13 Mar 2017 08:19:51 +0100 [thread overview]
Message-ID: <20170313071951.bozyaflcqj45zzlt@pengutronix.de> (raw)
In-Reply-To: <1489156876-25133-1-git-send-email-plagnioj@jcrosoft.com>
On Fri, Mar 10, 2017 at 03:41:16PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> on 64bit ssize_t is not an int but a long
>
> so use the protype for fops_write ssize_t
>
> common/console.c: In function ‘console_register’:
> common/console.c:373:22: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
> newcdev->fops.write = fops_write;
>
> in commit b4f55fcf355a4d0ac456445a5f42f259f2812b57
> By Bastian Stender <bst@pengutronix.de>
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> common/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/console.c b/common/console.c
> index 668c870ab..4127e7617 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -296,7 +296,7 @@ static int fops_flush(struct cdev *dev)
> return 0;
> }
>
> -static int fops_write(struct cdev* dev, const void* buf, size_t count,
> +static ssize_t fops_write(struct cdev* dev, const void* buf, size_t count,
> loff_t offset, ulong flags)
> {
> struct console_device *priv = dev->priv;
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-03-13 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 14:41 Jean-Christophe PLAGNIOL-VILLARD
2017-03-13 7:19 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313071951.bozyaflcqj45zzlt@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox