From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v3 2/4] led: Add blink/flash to led command
Date: Mon, 13 Mar 2017 10:33:37 +0100 [thread overview]
Message-ID: <20170313093339.12597-3-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20170313093339.12597-1-o.rempel@pengutronix.de>
From: Sascha Hauer <s.hauer@pengutronix.de>
The LED framework now supports blinking/flashing LEDs, so
add this functionality to the led command.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
commands/led.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/commands/led.c b/commands/led.c
index 354f74df8..a53f0df6a 100644
--- a/commands/led.c
+++ b/commands/led.c
@@ -29,6 +29,44 @@ static int do_led(int argc, char *argv[])
unsigned long value;
struct led *led;
int ret;
+ int opt;
+ int flash = 0, blink = 0;
+ int blink_on_ms = 500;
+ int blink_off_ms = 500;
+
+ while ((opt = getopt(argc, argv, "fb")) > 0) {
+ switch(opt) {
+ case 'f':
+ flash = 1;
+ break;
+ case 'b':
+ blink = 1;
+ break;
+ }
+ }
+
+ if (flash || blink) {
+ int args = argc - optind;
+
+ if (!args || (flash && blink))
+ return COMMAND_ERROR_USAGE;
+
+ led = led_by_name_or_number(argv[optind]);
+ if (!led) {
+ printf("no such LED: %s\n", argv[optind]);
+ return 1;
+ }
+
+ if (args > 1)
+ blink_on_ms = simple_strtoul(argv[optind + 1], NULL, 0);
+ if (args > 2)
+ blink_off_ms = simple_strtoul(argv[optind + 2], NULL, 0);
+
+ if (flash)
+ return led_flash(led, blink_on_ms);
+ if (blink)
+ return led_blink(led, blink_on_ms, blink_off_ms);
+ }
if (argc == 1) {
int i = 0;
@@ -73,9 +111,13 @@ static int do_led(int argc, char *argv[])
BAREBOX_CMD_HELP_START(led)
BAREBOX_CMD_HELP_TEXT("Control the value of a LED. The exact meaning of VALUE is unspecified,")
BAREBOX_CMD_HELP_TEXT("it can be a brightness, or a color. Most often a value of '1' means on")
-BAREBOX_CMD_HELP_TEXT("and '0' means off.")
+BAREBOX_CMD_HELP_TEXT("and '0' means off. Basic usage is 'led <led> <value>'. LEDs can be given")
+BAREBOX_CMD_HELP_TEXT("by name or number.")
BAREBOX_CMD_HELP_TEXT("")
BAREBOX_CMD_HELP_TEXT("Without arguments the available LEDs are listed.")
+BAREBOX_CMD_HELP_TEXT("Options:")
+BAREBOX_CMD_HELP_OPT ("-b <led> [duration-on-ms] [duration-off-ms]", "blink a LED")
+BAREBOX_CMD_HELP_OPT ("-f <led> [duration-ms]", "flash a LED")
BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(led)
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-03-13 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 9:33 [PATCH v3 0/4] upstream led blinking rework Oleksij Rempel
2017-03-13 9:33 ` [PATCH v3 1/4] led: add blinking/flashing and led_blink_pattern interface Oleksij Rempel
2017-03-13 9:33 ` Oleksij Rempel [this message]
2017-03-13 9:33 ` [PATCH v3 3/4] led: trigger: Use led triggers Oleksij Rempel
2017-03-13 9:33 ` [PATCH v3 4/4] led-trigger: Allow multiple led triggers of the same type Oleksij Rempel
2017-03-14 7:11 ` [PATCH v3 0/4] upstream led blinking rework Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313093339.12597-3-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox