From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v8 6/7] common: password: make use of get_crypto_bytes
Date: Wed, 22 Mar 2017 10:14:38 +0100 [thread overview]
Message-ID: <20170322091439.18187-7-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20170322091439.18187-1-o.rempel@pengutronix.de>
get_random_bytes is providing prng, if we have HWRNG we should be
able to use it over get_crypto_bytes
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
common/password.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/common/password.c b/common/password.c
index d52b746f0..74d328f4b 100644
--- a/common/password.c
+++ b/common/password.c
@@ -365,7 +365,11 @@ int set_env_passwd(unsigned char* passwd, size_t length)
char *salt = passwd_sum;
int keylen = PBKDF2_LENGTH - PBKDF2_SALT_LEN;
- get_random_bytes(passwd_sum, PBKDF2_SALT_LEN);
+ ret = get_crypto_bytes(passwd_sum, PBKDF2_SALT_LEN);
+ if (ret) {
+ pr_err("Can't get random numbers\n");
+ return ret;
+ }
ret = pkcs5_pbkdf2_hmac_sha1(passwd, length, salt,
PBKDF2_SALT_LEN, PBKDF2_COUNT, keylen, key);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-03-22 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 9:14 [PATCH v8 0/7] upstream hwrng framework Oleksij Rempel
2017-03-22 9:14 ` [PATCH v8 1/7] drivers: add simple hw_random implementation Oleksij Rempel
2017-03-22 9:14 ` [PATCH v8 2/7] lib: random: add get_crypto_bytes interface and use HWRNG if posssible Oleksij Rempel
2017-03-22 9:14 ` [PATCH v8 3/7] caamrng: port to hwrng framework Oleksij Rempel
2017-03-22 9:14 ` [PATCH v8 4/7] fs: add prng device Oleksij Rempel
2017-03-22 9:14 ` [PATCH v8 5/7] crypto: caam - fix RNG buffer cache alignment Oleksij Rempel
2017-03-22 9:14 ` Oleksij Rempel [this message]
2017-03-22 9:14 ` [PATCH v8 7/7] add seed command Oleksij Rempel
2017-03-24 6:13 ` [PATCH v8 0/7] upstream hwrng framework Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322091439.18187-7-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox