From: Peter Mamonov <pmamonov@gmail.com>
To: barebox@lists.infradead.org
Cc: Peter Mamonov <pmamonov@gmail.com>
Subject: [PATCH] usb_kbd: release all keys on error / disconnect
Date: Thu, 23 Mar 2017 00:38:03 +0300 [thread overview]
Message-ID: <20170322213803.24634-1-pmamonov@gmail.com> (raw)
Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
---
drivers/input/usb_kbd.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/input/usb_kbd.c b/drivers/input/usb_kbd.c
index 2acc95d9f..a2b92c285 100644
--- a/drivers/input/usb_kbd.c
+++ b/drivers/input/usb_kbd.c
@@ -58,6 +58,14 @@ struct usb_kbd_pdata {
struct input_device input;
};
+static void usb_kbd_release_all_keys(struct usb_kbd_pdata *data)
+{
+ int i;
+
+ for (i = 0; i <= KEY_MAX; i++)
+ input_report_key_event(&data->input, i, 0);
+}
+
static int usb_kbd_int_poll(struct usb_kbd_pdata *data)
{
return usb_submit_int_msg(data->usbdev, data->intpipe, data->new,
@@ -98,6 +106,8 @@ static void usb_kbd_poll(void *arg)
int ret, i;
ret = data->do_poll(data);
+ if (ret < 0)
+ usb_kbd_release_all_keys(data);
if (ret == -EAGAIN)
goto exit;
if (ret < 0) {
@@ -209,6 +219,7 @@ static void usb_kbd_disconnect(struct usb_device *usbdev)
{
struct usb_kbd_pdata *data = usbdev->drv_data;
+ usb_kbd_release_all_keys(data);
poller_async_unregister(&data->poller);
input_device_unregister(&data->input);
dma_free(data->new);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2017-03-22 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 21:38 Peter Mamonov [this message]
2017-03-24 6:15 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322213803.24634-1-pmamonov@gmail.com \
--to=pmamonov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox