* [PATCH] usb_kbd: release all keys on error / disconnect
@ 2017-03-22 21:38 Peter Mamonov
2017-03-24 6:15 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Peter Mamonov @ 2017-03-22 21:38 UTC (permalink / raw)
To: barebox; +Cc: Peter Mamonov
Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
---
drivers/input/usb_kbd.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/input/usb_kbd.c b/drivers/input/usb_kbd.c
index 2acc95d9f..a2b92c285 100644
--- a/drivers/input/usb_kbd.c
+++ b/drivers/input/usb_kbd.c
@@ -58,6 +58,14 @@ struct usb_kbd_pdata {
struct input_device input;
};
+static void usb_kbd_release_all_keys(struct usb_kbd_pdata *data)
+{
+ int i;
+
+ for (i = 0; i <= KEY_MAX; i++)
+ input_report_key_event(&data->input, i, 0);
+}
+
static int usb_kbd_int_poll(struct usb_kbd_pdata *data)
{
return usb_submit_int_msg(data->usbdev, data->intpipe, data->new,
@@ -98,6 +106,8 @@ static void usb_kbd_poll(void *arg)
int ret, i;
ret = data->do_poll(data);
+ if (ret < 0)
+ usb_kbd_release_all_keys(data);
if (ret == -EAGAIN)
goto exit;
if (ret < 0) {
@@ -209,6 +219,7 @@ static void usb_kbd_disconnect(struct usb_device *usbdev)
{
struct usb_kbd_pdata *data = usbdev->drv_data;
+ usb_kbd_release_all_keys(data);
poller_async_unregister(&data->poller);
input_device_unregister(&data->input);
dma_free(data->new);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb_kbd: release all keys on error / disconnect
2017-03-22 21:38 [PATCH] usb_kbd: release all keys on error / disconnect Peter Mamonov
@ 2017-03-24 6:15 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-03-24 6:15 UTC (permalink / raw)
To: Peter Mamonov; +Cc: barebox
On Thu, Mar 23, 2017 at 12:38:03AM +0300, Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/input/usb_kbd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/input/usb_kbd.c b/drivers/input/usb_kbd.c
> index 2acc95d9f..a2b92c285 100644
> --- a/drivers/input/usb_kbd.c
> +++ b/drivers/input/usb_kbd.c
> @@ -58,6 +58,14 @@ struct usb_kbd_pdata {
> struct input_device input;
> };
>
> +static void usb_kbd_release_all_keys(struct usb_kbd_pdata *data)
> +{
> + int i;
> +
> + for (i = 0; i <= KEY_MAX; i++)
> + input_report_key_event(&data->input, i, 0);
> +}
> +
> static int usb_kbd_int_poll(struct usb_kbd_pdata *data)
> {
> return usb_submit_int_msg(data->usbdev, data->intpipe, data->new,
> @@ -98,6 +106,8 @@ static void usb_kbd_poll(void *arg)
> int ret, i;
>
> ret = data->do_poll(data);
> + if (ret < 0)
> + usb_kbd_release_all_keys(data);
> if (ret == -EAGAIN)
> goto exit;
> if (ret < 0) {
> @@ -209,6 +219,7 @@ static void usb_kbd_disconnect(struct usb_device *usbdev)
> {
> struct usb_kbd_pdata *data = usbdev->drv_data;
>
> + usb_kbd_release_all_keys(data);
> poller_async_unregister(&data->poller);
> input_device_unregister(&data->input);
> dma_free(data->new);
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-24 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 21:38 [PATCH] usb_kbd: release all keys on error / disconnect Peter Mamonov
2017-03-24 6:15 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox