mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] video: ipu: convert "failed to get modes" message to dev_dbg
@ 2017-03-23 13:22 Sascha Hauer
  2017-03-23 13:22 ` [PATCH 2/2] video: ipu: register framebuffer, even when no modes are found Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2017-03-23 13:22 UTC (permalink / raw)
  To: Barebox List

When no monitor is connected the it's normal for some outputs
that no modes can be found. Convert dev_err to dev_dbg to decrease
the visibility of this message.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/video/imx-ipu-v3/ipufb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/imx-ipu-v3/ipufb.c b/drivers/video/imx-ipu-v3/ipufb.c
index 343f9e5578..4781c45098 100644
--- a/drivers/video/imx-ipu-v3/ipufb.c
+++ b/drivers/video/imx-ipu-v3/ipufb.c
@@ -334,7 +334,7 @@ static int ipufb_probe(struct device_d *dev)
 
 		ret = vpl_ioctl(&fbi->vpl, 2 + fbi->dino, VPL_GET_VIDEOMODES, &info->modes);
 		if (ret) {
-			dev_err(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
+			dev_dbg(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
 			return ret;
 		}
 
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2/2] video: ipu: register framebuffer, even when no modes are found
  2017-03-23 13:22 [PATCH 1/2] video: ipu: convert "failed to get modes" message to dev_dbg Sascha Hauer
@ 2017-03-23 13:22 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-03-23 13:22 UTC (permalink / raw)
  To: Barebox List

When no monitor is connected it might be normal that no modes are found.
Do not bail out with an error in this case, which gives an ugly error
message, but instead still register the framebuffer. This gives the
user a chance to examine it and see that the framebuffer has no modes.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/video/imx-ipu-v3/ipufb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/imx-ipu-v3/ipufb.c b/drivers/video/imx-ipu-v3/ipufb.c
index 4781c45098..9597eda0d0 100644
--- a/drivers/video/imx-ipu-v3/ipufb.c
+++ b/drivers/video/imx-ipu-v3/ipufb.c
@@ -333,10 +333,8 @@ static int ipufb_probe(struct device_d *dev)
 		}
 
 		ret = vpl_ioctl(&fbi->vpl, 2 + fbi->dino, VPL_GET_VIDEOMODES, &info->modes);
-		if (ret) {
+		if (ret)
 			dev_dbg(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
-			return ret;
-		}
 
 		ret = register_framebuffer(info);
 		if (ret < 0) {
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-23 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-23 13:22 [PATCH 1/2] video: ipu: convert "failed to get modes" message to dev_dbg Sascha Hauer
2017-03-23 13:22 ` [PATCH 2/2] video: ipu: register framebuffer, even when no modes are found Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox