From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb_kbd: release all keys on error / disconnect
Date: Fri, 24 Mar 2017 07:15:45 +0100 [thread overview]
Message-ID: <20170324061545.6tf7rlj3hroazq2k@pengutronix.de> (raw)
In-Reply-To: <20170322213803.24634-1-pmamonov@gmail.com>
On Thu, Mar 23, 2017 at 12:38:03AM +0300, Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/input/usb_kbd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/input/usb_kbd.c b/drivers/input/usb_kbd.c
> index 2acc95d9f..a2b92c285 100644
> --- a/drivers/input/usb_kbd.c
> +++ b/drivers/input/usb_kbd.c
> @@ -58,6 +58,14 @@ struct usb_kbd_pdata {
> struct input_device input;
> };
>
> +static void usb_kbd_release_all_keys(struct usb_kbd_pdata *data)
> +{
> + int i;
> +
> + for (i = 0; i <= KEY_MAX; i++)
> + input_report_key_event(&data->input, i, 0);
> +}
> +
> static int usb_kbd_int_poll(struct usb_kbd_pdata *data)
> {
> return usb_submit_int_msg(data->usbdev, data->intpipe, data->new,
> @@ -98,6 +106,8 @@ static void usb_kbd_poll(void *arg)
> int ret, i;
>
> ret = data->do_poll(data);
> + if (ret < 0)
> + usb_kbd_release_all_keys(data);
> if (ret == -EAGAIN)
> goto exit;
> if (ret < 0) {
> @@ -209,6 +219,7 @@ static void usb_kbd_disconnect(struct usb_device *usbdev)
> {
> struct usb_kbd_pdata *data = usbdev->drv_data;
>
> + usb_kbd_release_all_keys(data);
> poller_async_unregister(&data->poller);
> input_device_unregister(&data->input);
> dma_free(data->new);
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-03-24 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 21:38 Peter Mamonov
2017-03-24 6:15 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324061545.6tf7rlj3hroazq2k@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox