mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: uhci-hcd: fix uhci_alloc_int_td()
Date: Fri, 24 Mar 2017 07:20:55 +0100	[thread overview]
Message-ID: <20170324062055.f7oeacmhkm3hkizj@pengutronix.de> (raw)
In-Reply-To: <20170322213615.24527-1-pmamonov@gmail.com>

Hi Peter,

On Thu, Mar 23, 2017 at 12:36:15AM +0300, Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
>  drivers/usb/host/uhci-hcd.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
> index 9ad4644e8..04d167ee3 100644
> --- a/drivers/usb/host/uhci-hcd.c
> +++ b/drivers/usb/host/uhci-hcd.c
> @@ -554,8 +554,12 @@ static int submit_bulk_msg(struct usb_device *dev, unsigned long pipe,
>   */
>  static struct uhci_td *uhci_alloc_int_td(struct uhci_priv *uhci)
>  {
> -	return &uhci->tmp_int_td[0];
> +	int i;
>  
> +	for (i = 0; i < USB_MAX_TEMP_INT_TD; i++)
> +		if (uhci->tmp_int_td[i].dev_ptr == 0)
> +			return &uhci->tmp_int_td[i];
> +	return NULL;

You have to upstream the uhci driver first before I can apply fixes for
it ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-03-24  6:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 21:36 Peter Mamonov
2017-03-24  6:20 ` Sascha Hauer [this message]
2017-04-05 10:05   ` Peter Mamonov
2017-04-06  7:04     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324062055.f7oeacmhkm3hkizj@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=pmamonov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox