From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] console: console_get_by_name: do not strcmp NULL
Date: Wed, 29 Mar 2017 08:50:32 +0200 [thread overview]
Message-ID: <20170329065032.qzav23kufhpoyffr@pengutronix.de> (raw)
In-Reply-To: <1490537832-14971-1-git-send-email-akurz@blala.de>
On Sun, Mar 26, 2017 at 04:17:12PM +0200, Alexander Kurz wrote:
> console_get_by_name iterates through the console_list using strcmp to mach
> a given console by name. console_list may contain entries with devname = NULL,
> inserted there e.g. by KEYBOARD_GPIO. In worst case loady -t usbserial
> will crash barebox when strcmp hits 0 NULL devname:
> > unable to handle NULL pointer dereference at address 0x00000000
>
> Let console_get_by_name just ignore the anonymous consoles.
>
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
Applied to master, thanks
Sascha
> common/console_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/console_common.c b/common/console_common.c
> index 2e5869f..d051458 100644
> --- a/common/console_common.c
> +++ b/common/console_common.c
> @@ -246,7 +246,7 @@ struct console_device *console_get_by_name(const char *name)
> struct console_device *cdev;
>
> for_each_console(cdev) {
> - if (!strcmp(cdev->devname, name))
> + if (cdev->devname && !strcmp(cdev->devname, name))
> return cdev;
> }
>
> --
> 2.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-03-29 6:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 14:17 Alexander Kurz
2017-03-29 6:50 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329065032.qzav23kufhpoyffr@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=akurz@blala.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox