From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 08/14] of: partition: Make partition fixup independent from mtd devices
Date: Fri, 31 Mar 2017 07:33:17 +0200 [thread overview]
Message-ID: <20170331053323.17821-9-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20170331053323.17821-1-s.hauer@pengutronix.de>
The of partition parser is not only used for mtd device, but also
for regular block devices, so make the of_mtd_fixup code independent
of mtd devices also, so that other devices can be fixed up, too.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/of/partition.c | 36 +++++++++++++++++++-----------------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/drivers/of/partition.c b/drivers/of/partition.c
index 30df6b32d1..9b96a39edb 100644
--- a/drivers/of/partition.c
+++ b/drivers/of/partition.c
@@ -98,6 +98,8 @@ int of_parse_partitions(struct cdev *cdev, struct device_node *node)
if (!node)
return -EINVAL;
+ cdev->device_node = node;
+
subnode = of_get_child_by_name(node, "partitions");
if (subnode) {
if (!of_device_is_compatible(subnode, "fixed-partitions"))
@@ -124,28 +126,28 @@ static void delete_subnodes(struct device_node *np)
}
}
-static int of_mtd_fixup(struct device_node *root, void *ctx)
+static int of_partition_fixup(struct device_node *root, void *ctx)
{
- struct cdev *cdev = ctx;
- struct mtd_info *mtd, *partmtd;
+ struct cdev *cdev = ctx, *partcdev;
struct device_node *np, *part, *partnode;
int ret;
int n_cells;
- mtd = container_of(cdev, struct mtd_info, cdev);
-
if (of_partition_binding == MTD_OF_BINDING_DONTTOUCH)
return 0;
- if (mtd->size >= 0x100000000)
+ if (!cdev->device_node)
+ return -EINVAL;
+
+ if (cdev->size >= 0x100000000)
n_cells = 2;
else
n_cells = 1;
- np = of_find_node_by_path_from(root, mtd->of_path);
+ np = of_find_node_by_path_from(root, cdev->device_node->full_name);
if (!np) {
- dev_err(&mtd->class_dev, "Cannot find nodepath %s, cannot fixup\n",
- mtd->of_path);
+ dev_err(cdev->dev, "Cannot find nodepath %s, cannot fixup\n",
+ cdev->device_node->full_name);
return -EINVAL;
}
@@ -180,10 +182,10 @@ static int of_mtd_fixup(struct device_node *root, void *ctx)
if (ret)
return ret;
- list_for_each_entry(partmtd, &mtd->partitions, partitions_entry) {
+ list_for_each_entry(partcdev, &cdev->partitions, partition_entry) {
int na, ns, len = 0;
char *name = basprintf("partition@%0llx",
- partmtd->master_offset);
+ partcdev->offset);
void *p;
u8 tmp[16 * 16]; /* Up to 64-bit address + 64-bit size */
@@ -195,24 +197,24 @@ static int of_mtd_fixup(struct device_node *root, void *ctx)
if (!part)
return -ENOMEM;
- p = of_new_property(part, "label", partmtd->cdev.partname,
- strlen(partmtd->cdev.partname) + 1);
+ p = of_new_property(part, "label", partcdev->partname,
+ strlen(partcdev->partname) + 1);
if (!p)
return -ENOMEM;
na = of_n_addr_cells(part);
ns = of_n_size_cells(part);
- of_write_number(tmp + len, partmtd->master_offset, na);
+ of_write_number(tmp + len, partcdev->offset, na);
len += na * 4;
- of_write_number(tmp + len, partmtd->size, ns);
+ of_write_number(tmp + len, partcdev->size, ns);
len += ns * 4;
ret = of_set_property(part, "reg", tmp, len, 1);
if (ret)
return ret;
- if (partmtd->cdev.flags & DEVFS_PARTITION_READONLY) {
+ if (partcdev->flags & DEVFS_PARTITION_READONLY) {
ret = of_set_property(part, "read-only", NULL, 0, 1);
if (ret)
return ret;
@@ -224,7 +226,7 @@ static int of_mtd_fixup(struct device_node *root, void *ctx)
int of_partitions_register_fixup(struct cdev *cdev)
{
- return of_register_fixup(of_mtd_fixup, cdev);
+ return of_register_fixup(of_partition_fixup, cdev);
}
static const char *of_binding_names[] = {
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-03-31 5:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 5:33 OF partitions rework Sascha Hauer
2017-03-31 5:33 ` [PATCH 01/14] of: Add of_property_write_string() Sascha Hauer
2017-03-31 5:33 ` [PATCH 02/14] treewide: Use of_property_write_string() where appropriate Sascha Hauer
2017-03-31 5:33 ` [PATCH 03/14] of: partition: Move of_mtd_fixup to drivers/of/ Sascha Hauer
2017-03-31 5:33 ` [PATCH 04/14] mtd: of: Make used partition binding configurable Sascha Hauer
2017-03-31 5:33 ` [PATCH 05/14] of: partition: support 64bit partition sizes Sascha Hauer
2017-03-31 5:33 ` [PATCH 06/14] mtd: partition: set cdev->offset to the actual offset Sascha Hauer
2017-03-31 8:46 ` Sascha Hauer
2017-03-31 5:33 ` [PATCH 07/14] cdev: Collect partitions on list Sascha Hauer
2017-03-31 5:33 ` Sascha Hauer [this message]
2017-03-31 5:33 ` [PATCH 09/14] fs: devfs-core: remove unused code Sascha Hauer
2017-03-31 5:33 ` [PATCH 10/14] fs: devfs-core: replace DEVFS_PARTITION_FIXED flag with pointer to the master cdev Sascha Hauer
2017-03-31 5:33 ` [PATCH 11/14] of: partition: only create partition node when partitions exist Sascha Hauer
2017-03-31 5:33 ` [PATCH 12/14] of: partitions: flag partitions from a partition table Sascha Hauer
2017-03-31 5:33 ` [PATCH 13/14] of: partition: Register the of partition fixup for of partition users Sascha Hauer
2017-03-31 5:33 ` [PATCH 14/14] of: of_path: add of_find_node_by_devpath() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331053323.17821-9-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox