mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1] usb: gadget: set otg to peripheral mode on autostart
Date: Mon, 3 Apr 2017 08:04:17 +0200	[thread overview]
Message-ID: <20170403060417.mtq4cnkgft3256rc@pengutronix.de> (raw)
In-Reply-To: <20170331173436.10767-1-o.rempel@pengutronix.de>

Hi Oleksij,

On Fri, Mar 31, 2017 at 07:34:36PM +0200, Oleksij Rempel wrote:
> we won't be able to start if otg is not properly configured.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/usb/gadget/autostart.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/gadget/autostart.c b/drivers/usb/gadget/autostart.c
> index 43c2ba23d..87781a11a 100644
> --- a/drivers/usb/gadget/autostart.c
> +++ b/drivers/usb/gadget/autostart.c
> @@ -14,6 +14,7 @@
>  #include <common.h>
>  #include <command.h>
>  #include <errno.h>
> +#include <environment.h>
>  #include <malloc.h>
>  #include <getopt.h>
>  #include <fs.h>
> @@ -31,10 +32,15 @@ static char *fastboot_function;
>  static int usbgadget_autostart(void)
>  {
>  	struct f_multi_opts opts = {};
> +	int ret;
>  
>  	if (!autostart)
>  		return 0;
>  
> +	ret = setenv("otg.mode", "peripheral");
> +	if (ret)
> +		return ret;

When the USB device is not a i.MX chipidea or MUSB controller, or the
device is set to device mode in the device tree, then the otg device
won't exist. You have to ignore the error value from setenv.

Sascha



-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2017-04-03  6:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 17:34 Oleksij Rempel
2017-04-03  6:04 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170403060417.mtq4cnkgft3256rc@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox