From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cw1TK-0003B6-IQ for barebox@lists.infradead.org; Thu, 06 Apr 2017 07:04:48 +0000 Date: Thu, 6 Apr 2017 09:04:24 +0200 From: Sascha Hauer Message-ID: <20170406070424.ybniwgrulvmmdwzr@pengutronix.de> References: <20170322213615.24527-1-pmamonov@gmail.com> <20170324062055.f7oeacmhkm3hkizj@pengutronix.de> <20170405100547.GA16849@berta> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170405100547.GA16849@berta> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] usb: uhci-hcd: fix uhci_alloc_int_td() To: Peter Mamonov Cc: barebox@lists.infradead.org On Wed, Apr 05, 2017 at 01:05:47PM +0300, Peter Mamonov wrote: > Hi Sasha, > > On Fri, Mar 24, 2017 at 07:20:55AM +0100, Sascha Hauer wrote: > > Hi Peter, > > > > On Thu, Mar 23, 2017 at 12:36:15AM +0300, Peter Mamonov wrote: > > > Signed-off-by: Peter Mamonov > > > --- > > > drivers/usb/host/uhci-hcd.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c > > > index 9ad4644e8..04d167ee3 100644 > > > --- a/drivers/usb/host/uhci-hcd.c > > > +++ b/drivers/usb/host/uhci-hcd.c > > > @@ -554,8 +554,12 @@ static int submit_bulk_msg(struct usb_device *dev, unsigned long pipe, > > > */ > > > static struct uhci_td *uhci_alloc_int_td(struct uhci_priv *uhci) > > > { > > > - return &uhci->tmp_int_td[0]; > > > + int i; > > > > > > + for (i = 0; i < USB_MAX_TEMP_INT_TD; i++) > > > + if (uhci->tmp_int_td[i].dev_ptr == 0) > > > + return &uhci->tmp_int_td[i]; > > > + return NULL; > > > > You have to upstream the uhci driver first before I can apply fixes for > > it ;) > > Right =) > > I've just realized it was not accepted... for a good reason: > http://lists.infradead.org/pipermail/barebox/2016-January/026016.html Well the driver doesn't look bad from a first glance. You could repost it with your fixup applied and see what the maintainer says ;) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox