mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] lib/strtox: remove unnecessary islower()
Date: Sat, 15 Apr 2017 10:24:44 +0200	[thread overview]
Message-ID: <20170415082444.GB20400@ravnborg.org> (raw)
In-Reply-To: <20170411063934.20613-2-s.hauer@pengutronix.de>

On Tue, Apr 11, 2017 at 08:39:34AM +0200, Sascha Hauer wrote:
> toupper() does the right thing, no need to test for islower()
> beforehand, so
> 
> islower(*cp) ? toupper(*cp) : *cp
> 
> can be simplified to:
> 
> toupper(*cp)
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-04-15  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  6:39 [PATCH 1/2] lib/strtox: whitespace cleanup Sascha Hauer
2017-04-11  6:39 ` [PATCH 2/2] lib/strtox: remove unnecessary islower() Sascha Hauer
2017-04-15  8:24   ` Sam Ravnborg [this message]
2017-04-15  8:22 ` [PATCH 1/2] lib/strtox: whitespace cleanup Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170415082444.GB20400@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox