mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Matt Reimer <mreimer@sdgsystems.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: nand_omap_gpmc: fix BCH error correction
Date: Wed, 19 Apr 2017 10:10:08 +0200	[thread overview]
Message-ID: <20170419081008.i6unqcli7fhmq5xd@pengutronix.de> (raw)
In-Reply-To: <20170414183205.62794-1-mreimer@sdgsystems.com>

Hi Matt,

On Fri, Apr 14, 2017 at 11:32:05AM -0700, Matt Reimer wrote:
> BCH error detection and correction was only looking at the first
> of four syndrome polynomials, which meant it was failing to detect
> and correct bitflips in the last 3/4 of the data. In effect, only
> the first 512 bytes of a 2048 byte page were being protected by ECC.
> 
> The syndrome polynomials (BCH error codes) are stored in the NAND's
> OOB, each of which protects 512 bytes of data. The driver used
> eccsteps = 1 which effectively made it only use the first polynomial,
> and therefore was only protecting the first 512 bytes of the page.
> 
> The fix is to pull over a bit of code from the kernel's
> omap_correct_data() that sets eccsteps = 4 when the page size is 2048
> bytes and hardware ECC is being used.
> 
> Signed-off-by: Matt Reimer <mreimer@sdgsystems.com>
> ---
>  drivers/mtd/nand/nand_omap_gpmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c
> index 9d9d27e..2fe6a10 100644
> --- a/drivers/mtd/nand/nand_omap_gpmc.c
> +++ b/drivers/mtd/nand/nand_omap_gpmc.c
> @@ -302,7 +302,8 @@ static int omap_correct_bch(struct mtd_info *mtd, uint8_t *dat,
>  	unsigned int err_loc[8];
>  	int select_4_8;
>  
> -	int eccsteps = oinfo->nand.ecc.steps;
> +        int eccsteps = (nand->ecc.mode == NAND_ECC_HW) &&
> +                (nand->ecc.size == 2048) ? 4 : 1;

Fixed up indention and applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-04-19  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 18:32 Matt Reimer
2017-04-19  8:10 ` Sascha Hauer [this message]
2017-05-26 12:28 ` Daniel Schultz
  -- strict thread matches above, loose matches on Subject: below --
2017-04-14 18:29 Matt Reimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419081008.i6unqcli7fhmq5xd@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mreimer@sdgsystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox