mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: m25p80: make it possible to use 4K erase block
Date: Fri, 28 Apr 2017 10:18:48 +0200	[thread overview]
Message-ID: <20170428081848.bvfttqhjhfpewjqi@pengutronix.de> (raw)
In-Reply-To: <20170426141734.18670-1-antonynpavlov@gmail.com>

On Wed, Apr 26, 2017 at 05:17:34PM +0300, Antony Pavlov wrote:
> We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code
> for 4K erase block support. Alas this 4K erase block support code
> can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support
> is missed in Kconfig.
> 
> This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option
> declaration from linux v4.11-rc8.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index a84591fdd1..8ede3c90be 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR
>  
>  if MTD_SPI_NOR
>  
> +config MTD_SPI_NOR_USE_4K_SECTORS
> +	bool "Use small 4096 B erase sectors"
> +	default y

This changes the default which breaks existing UBI users. Can you drop
this?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-04-28  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 14:17 Antony Pavlov
2017-04-28  8:18 ` Sascha Hauer [this message]
2017-04-28 10:57   ` Antony Pavlov
2017-10-12 17:01     ` Antony Pavlov
2017-10-16  7:26       ` Sascha Hauer
2017-10-16 14:04         ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428081848.bvfttqhjhfpewjqi@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox