mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/7] arm: boards: beaglebone: Update boot scripts
Date: Tue, 2 May 2017 09:11:39 +0200	[thread overview]
Message-ID: <20170502071139.ah4ukxeqqjn47i6s@pengutronix.de> (raw)
In-Reply-To: <1493383568-27798-6-git-send-email-d.schultz@phytec.de>

On Fri, Apr 28, 2017 at 02:46:07PM +0200, Daniel Schultz wrote:
> Remove the current SD boot script and add support for MMC, EMMC and
> network bootsources.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/emmc  |  9 +++++++++
>  arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/mmc   |  9 +++++++++
>  arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd    |  6 ------
>  .../boards/beaglebone/defaultenv-beaglebone/init/bootsource | 13 +++++++++++++
>  4 files changed, 31 insertions(+), 6 deletions(-)
>  create mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/emmc
>  create mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/mmc
>  delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd
>  create mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/init/bootsource
> 
> diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/emmc b/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/emmc
> new file mode 100644
> index 0000000..5734e3b
> --- /dev/null
> +++ b/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/emmc
> @@ -0,0 +1,9 @@
> +#!/bin/sh
> +
> +if [ -e /mnt/emmc/linuximage ]
> +	global.bootm.image=/mnt/emmc/linuximage
> +else
> +	global.bootm.image=/mnt/emmc/uImage
> +fi
> +global.bootm.oftree=/mnt/emmc/oftree
> +global.linux.bootargs.dyn.root="root=/dev/mmcblk1p2 rootflags='data=journal'"

I know I asked this quite some times already, but: Why not bootloader
spec? grepping for "global.bootm.image=" shows that we expect the kernel
at "/linuximage", "/zImage" or "/uImage", depending on the board.
"data=journal" is only valid for ext4 and even there is not an option
everybody wants to have.
With bootloader spec the rootfs can describe itself which kernel(s)
shall be started with which devicetrees. From barebox it's easy aswell,
only type "boot mmcx" and you're done.

With these bootscripts the first one who comes decides how the board is
intended to be used. I really don't want to have this in generic boards.

Sascha



-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-05-02  7:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 12:46 [PATCH 1/7] arm: mach-omap: Change file flags in emmc handler Daniel Schultz
2017-04-28 12:46 ` [PATCH 2/7] arm: boards: Add MLO handler for EMMC devices Daniel Schultz
2017-04-28 12:46 ` [PATCH 3/7] arm: mach-omap: Change mountpoint of boot partitions Daniel Schultz
2017-05-02  6:52   ` Sascha Hauer
2017-04-28 12:46 ` [PATCH 4/7] arm: boards: phytec-som-am335x: Add automount script Daniel Schultz
2017-04-28 12:46 ` [PATCH 5/7] arm: boards: phytec-som-am335x: Update boot scripts Daniel Schultz
2017-04-28 12:46 ` [PATCH 6/7] arm: boards: beaglebone: " Daniel Schultz
2017-05-02  7:11   ` Sascha Hauer [this message]
2017-04-28 12:46 ` [PATCH 7/7] arm: boards: afi-gf: Update SD card boot script Daniel Schultz
2017-05-05  7:03 ` [PATCH 1/7] arm: mach-omap: Change file flags in emmc handler Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170502071139.ah4ukxeqqjn47i6s@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=d.schultz@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox