mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] ARM: i.MX: HAB: update documentation of command sequence files (CSF)
Date: Mon,  8 May 2017 15:25:20 +0200	[thread overview]
Message-ID: <20170508132520.13112-1-mkl@pengutronix.de> (raw)

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 arch/arm/mach-imx/include/mach/habv3-imx25-gencsf.h | 11 ++++++++---
 arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h  |  9 +++++----
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-imx/include/mach/habv3-imx25-gencsf.h b/arch/arm/mach-imx/include/mach/habv3-imx25-gencsf.h
index f4804fe63f19..60f730f8eca9 100644
--- a/arch/arm/mach-imx/include/mach/habv3-imx25-gencsf.h
+++ b/arch/arm/mach-imx/include/mach/habv3-imx25-gencsf.h
@@ -4,8 +4,8 @@
  * are expected in these config variables:
  *
  * CONFIG_HABV3_SRK_PEM
- * CONFIG_HABV3_SRK_PEM
- * CONFIG_HABV3_IMG_CRT_PEM
+ * CONFIG_HABV3_CSF_CRT_DER
+ * CONFIG_HABV3_IMG_CRT_DER
  */
 super_root_key CONFIG_HABV3_SRK_PEM
 
@@ -23,21 +23,26 @@ hab [Install SRK]
 hab File = "not-used"
 
 hab [Install CSFK]
+/* target key index in keystore 1 */
 hab File = CONFIG_HABV3_CSF_CRT_DER
 
 hab [Authenticate CSF]
-/* below is the command that unlock the access to the DryIce registers */
 
+/* unlock the access to the DryIce registers */
 hab [Write Data]
 hab Width = 4
 hab Address Data = 0x53FFC03C 0xCA693569
 
 hab [Install Key]
+/* verification key index in key store (1...4) */
+/* in contrast to documentation 0 seems to be valid, too */
 hab Verification index = 1
+/* target key index in key store (1...4) */
 hab Target index = 2
 hab File = CONFIG_HABV3_IMG_CRT_DER
 
 hab [Authenticate Data]
+/* verification key index in key store (2...4) */
 hab Verification index = 2
 
 hab_blocks
diff --git a/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h b/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h
index 1a143a8b1870..0649caa0cb88 100644
--- a/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h
+++ b/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h
@@ -22,6 +22,7 @@ hab # SRK index within SRK-Table 0..3
 hab Source index = 0
 
 hab [Install CSFK]
+/* target key index in keystore 1 */
 hab File = CONFIG_HABV4_CSF_CRT_PEM
 
 hab [Authenticate CSF]
@@ -31,14 +32,14 @@ hab Engine = CAAM
 hab Features = RNG
 
 hab [Install Key]
-/* verification key index in key store (0, 2...5) */
+/* verification key index in key store (0, 2...4) */
 hab Verification index = 0
-/* target key index in key store (2...5) */
+/* target key index in key store (2...4) */
 hab Target index = 2
 hab File = CONFIG_HABV4_IMG_CRT_PEM
 
 hab [Authenticate Data]
-/* verification key index in key store (2...5) */
+/* verification key index in key store (2...4) */
 hab Verification index = 2
 
-hab_blocks
\ No newline at end of file
+hab_blocks
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2017-05-08 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 13:25 Marc Kleine-Budde [this message]
2017-05-09  5:43 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170508132520.13112-1-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox