mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] state: remove unused variables
@ 2017-05-11  8:10 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2017-05-11  8:10 UTC (permalink / raw)
  To: Barebox List

There's no need to check for the existence of the backend property as
this is done implicitly later anyway. With this check removed of_path
is only assigned, but never used. Remove the unused code.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/state/state.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/common/state/state.c b/common/state/state.c
index b4a634fa99..878fd1b0fb 100644
--- a/common/state/state.c
+++ b/common/state/state.c
@@ -570,10 +570,8 @@ struct state *state_new_from_node(struct device_node *node, char *path,
 {
 	struct state *state;
 	int ret = 0;
-	int len;
 	const char *backend_type;
 	const char *storage_type;
-	const char *of_path;
 	const char *alias;
 	uint32_t stridesize;
 
@@ -587,12 +585,6 @@ struct state *state_new_from_node(struct device_node *node, char *path,
 	if (IS_ERR(state))
 		return state;
 
-	of_path = of_get_property(node, "backend", &len);
-	if (!of_path) {
-		ret = -ENODEV;
-		goto out_release_state;
-	}
-
 	if (!path) {
 		struct device_node *partition_node;
 
@@ -603,7 +595,6 @@ struct state *state_new_from_node(struct device_node *node, char *path,
 			goto out_release_state;
 		}
 
-		of_path = partition_node->full_name;
 		ret = of_find_path_by_node(partition_node, &path, 0);
 		if (ret) {
 			if (ret != -EPROBE_DEFER)
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-11  8:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-11  8:10 [PATCH] state: remove unused variables Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox