From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 4/4] arm: boards: beaglebone: Delete default env
Date: Wed, 17 May 2017 08:35:14 +0200 [thread overview]
Message-ID: <20170517063514.hexnde6jhbix5j3t@pengutronix.de> (raw)
In-Reply-To: <1494587239-33771-4-git-send-email-d.schultz@phytec.de>
On Fri, May 12, 2017 at 01:07:19PM +0200, Daniel Schultz wrote:
> The Beaglebone environment should be set from outside with an application
> specific environment.
>
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
> arch/arm/boards/beaglebone/Makefile | 1 -
> arch/arm/boards/beaglebone/board.c | 2 --
> arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd | 6 ------
> .../arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 | 5 -----
> 4 files changed, 14 deletions(-)
> delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd
> delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300
>
> --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -#!/bin/sh
> -
> -echo -n "changing USB current limit to 1300 mA... "
> -i2c_write -b 0 -a 0x24 -r 0x01 0x3e
> -echo "done"
We need this on the beagleboard. We can't just delete it without doing
this somewhere else.
Also I still do not understand the reasoning behind this change. Where
is "outside", to which application should the environment be specific
to?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-05-17 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 11:07 [PATCH v3 1/4] arm: mach-omap: Change mountpoint of boot partitions Daniel Schultz
2017-05-12 11:07 ` [PATCH v3 2/4] arm: boards: phytec-som-am335x: Add automount script Daniel Schultz
2017-05-17 6:26 ` Sascha Hauer
2017-06-02 7:59 ` Daniel Schultz
2017-05-12 11:07 ` [PATCH v3 3/4] arm: boards: phytec-som-am335x: Update boot scripts Daniel Schultz
2017-05-17 6:30 ` Sascha Hauer
2017-06-02 8:07 ` Daniel Schultz
2017-06-06 5:46 ` Sascha Hauer
2017-06-06 9:50 ` Daniel Schultz
2017-05-12 11:07 ` [PATCH v3 4/4] arm: boards: beaglebone: Delete default env Daniel Schultz
2017-05-17 6:35 ` Sascha Hauer [this message]
2017-06-06 10:57 ` Daniel Schultz
2017-05-17 6:25 ` [PATCH v3 1/4] arm: mach-omap: Change mountpoint of boot partitions Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517063514.hexnde6jhbix5j3t@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=d.schultz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox