mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Bastian Stender <bst@pengutronix.de>
Subject: Re: [PATCH] i2c: mv64xxx: fix indentation
Date: Tue, 23 May 2017 10:02:24 +0200	[thread overview]
Message-ID: <20170523080224.fabrnculzezwn3rx@pengutronix.de> (raw)
In-Reply-To: <20170522132934.9079-1-antonynpavlov@gmail.com>

On Mon, May 22, 2017 at 04:29:34PM +0300, Antony Pavlov wrote:
> The patch fixes this compiler's warning:
> 
>     drivers/i2c/busses/i2c-mv64xxx.c: In function ‘mv64xxx_i2c_fsm’:
>     drivers/i2c/busses/i2c-mv64xxx.c:303:3: warning: this ‘if’ clause does
>     not guard... [-Wmisleading-indentation]
>        if (drv_data->bytes_left == 1)
>        ^~
>     drivers/i2c/busses/i2c-mv64xxx.c:305:4: note: ...this statement, but the
>     latter is misleadingly indented as if it is guarded by the ‘if’
>         udelay(2);
>         ^~~~~~
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Bastian Stender <bst@pengutronix.de>

Applied, thanks

Sascha

> ---
>  drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 1a5d5ef9b..285ede84c 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -302,7 +302,7 @@ mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status)
>  
>  		if (drv_data->bytes_left == 1)
>  			drv_data->cntl_bits &= ~REG_CONTROL_ACK;
> -			udelay(2);
> +		udelay(2);
>  		break;
>  
>  	case STATUS_MAST_RD_DATA_NO_ACK: /* 0x58 */
> -- 
> 2.11.0
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2017-05-23  8:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 13:29 Antony Pavlov
2017-05-22 13:49 ` Bastian Stender
2017-05-23  8:02 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523080224.fabrnculzezwn3rx@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=bst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox