From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dGJdt-0006Zw-GZ for barebox@lists.infradead.org; Thu, 01 Jun 2017 06:31:35 +0000 Date: Thu, 1 Jun 2017 08:31:11 +0200 From: Sascha Hauer Message-ID: <20170601063111.k36wjyxac6uwslgv@pengutronix.de> References: <20170530140947.3988-1-p.zabel@pengutronix.de> <20170530140947.3988-4-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170530140947.3988-4-p.zabel@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/5] fs: add cdev_create_from_file for loop mount option To: Philipp Zabel Cc: barebox@lists.infradead.org Hi Philipp, On Tue, May 30, 2017 at 04:09:46PM +0200, Philipp Zabel wrote: > Allow to create a loopback cdev from a file. > > Signed-off-by: Philipp Zabel > --- > fs/devfs-core.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > fs/fs.c | 21 ++++++++++++--- > include/driver.h | 1 + > 3 files changed, 99 insertions(+), 4 deletions(-) > > diff --git a/fs/devfs-core.c b/fs/devfs-core.c > +static ssize_t loop_write(struct cdev *cdev, const void *buf, size_t count, > + loff_t offset, ulong flags) > +{ > + struct loop_priv *priv = cdev->priv; > + loff_t ofs; > + > + ofs = lseek(priv->fd, offset, SEEK_SET); > + if (ofs < 0) > + return ofs; > + > + return write(priv->fd, buf, count); > +} > + > +static const struct file_operations loop_ops = { > + .read = loop_read, > + .write = loop_write, > + .memmap = generic_memmap_rw, > + .lseek = dev_lseek_default, > +}; > + > +struct cdev *cdev_create_from_file(const char *path, ulong flags) Looks good, but I'm missing the counterpart of this function and its usage in umount(). Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox