From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
cphealy@gmail.com
Subject: [PATCH v3 1/4] gpio-imx: Do not use gpio_set_value()
Date: Sat, 3 Jun 2017 20:11:51 -0700 [thread overview]
Message-ID: <20170604031154.26663-2-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20170604031154.26663-1-andrew.smirnov@gmail.com>
Do not use gpio_set_value() in imx_gpio_direction_output(). We don't
check gpio_set_value's result, so calling imx_gpio_set_value()
directly instead should be as good.
Cc: cphealy@gmail.com
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Acked-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/gpio/gpio-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-imx.c b/drivers/gpio/gpio-imx.c
index ab4f596..a9d44d4 100644
--- a/drivers/gpio/gpio-imx.c
+++ b/drivers/gpio/gpio-imx.c
@@ -93,7 +93,7 @@ static int imx_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, int
void __iomem *base = imxgpio->base;
u32 val;
- gpio_set_value(gpio + chip->base, value);
+ imx_gpio_set_value(chip, gpio, value);
val = readl(base + imxgpio->regs->gdir);
val |= 1 << gpio;
--
2.9.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-06-04 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 3:11 [PATCH v3 0/4] GPIO "active low", hogging and usb-nop-xceive 'reset-gpio' support Andrey Smirnov
2017-06-04 3:11 ` Andrey Smirnov [this message]
2017-06-04 3:11 ` [PATCH v3 2/4] gpiolib: Add code to support "active low" GPIOs Andrey Smirnov
2017-06-04 3:11 ` [PATCH v3 3/4] gpiolib: Add support for GPIO "hog" nodes Andrey Smirnov
2017-06-04 3:11 ` [PATCH v3 4/4] usb-nop-xceiv: Add support for 'reset-gpios' binding Andrey Smirnov
2017-06-06 6:27 ` [PATCH v3 0/4] GPIO "active low", hogging and usb-nop-xceive 'reset-gpio' support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604031154.26663-2-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=cphealy@gmail.com \
--cc=nikita.yoush@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox