From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dHLxy-0000Kq-P0 for barebox@lists.infradead.org; Sun, 04 Jun 2017 03:12:36 +0000 Received: by mail-pf0-x244.google.com with SMTP id f27so16859920pfe.0 for ; Sat, 03 Jun 2017 20:12:15 -0700 (PDT) From: Andrey Smirnov Date: Sat, 3 Jun 2017 20:11:51 -0700 Message-Id: <20170604031154.26663-2-andrew.smirnov@gmail.com> In-Reply-To: <20170604031154.26663-1-andrew.smirnov@gmail.com> References: <20170604031154.26663-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v3 1/4] gpio-imx: Do not use gpio_set_value() To: barebox@lists.infradead.org Cc: Andrey Smirnov , Nikita Yushchenko , cphealy@gmail.com Do not use gpio_set_value() in imx_gpio_direction_output(). We don't check gpio_set_value's result, so calling imx_gpio_set_value() directly instead should be as good. Cc: cphealy@gmail.com Cc: Nikita Yushchenko Acked-by: Nikita Yushchenko Signed-off-by: Andrey Smirnov --- drivers/gpio/gpio-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-imx.c b/drivers/gpio/gpio-imx.c index ab4f596..a9d44d4 100644 --- a/drivers/gpio/gpio-imx.c +++ b/drivers/gpio/gpio-imx.c @@ -93,7 +93,7 @@ static int imx_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, int void __iomem *base = imxgpio->base; u32 val; - gpio_set_value(gpio + chip->base, value); + imx_gpio_set_value(chip, gpio, value); val = readl(base + imxgpio->regs->gdir); val |= 1 << gpio; -- 2.9.4 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox