Re: [PATCH v3 3/4] arm: boards: phytec-som-am335x: Update boot scripts

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Daniel,

On Fri, Jun 02, 2017 at 10:07:34AM +0200, Daniel Schultz wrote:
> Hi,
> 
> Am 17.05.2017 um 08:30 schrieb Sascha Hauer:
> > On Fri, May 12, 2017 at 01:07:18PM +0200, Daniel Schultz wrote:
> > > Expand the boot scripts with EMMC and add a default file source for
> > > expansions.
> > > 
> > > Removed "rw" and "rootwait" bootargs from existing boot scripts.
> > > Added "rootflags='data=journal'" bootarg to SD card boot script.
> > > 
> > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> > > ---
> > >   .../defaultenv-physom-am335x/boot/emmc                  |  7 +++++++
> > >   .../phytec-som-am335x/defaultenv-physom-am335x/boot/mmc |  7 ++++---
> > >   .../defaultenv-physom-am335x/boot/nand                  |  4 +++-
> > >   .../phytec-som-am335x/defaultenv-physom-am335x/boot/net | 17 +++++++++++++++++
> > >   .../phytec-som-am335x/defaultenv-physom-am335x/boot/spi |  4 +++-
> > >   .../defaultenv-physom-am335x/init/bootsource            | 16 ++++++++++++----
> > >   6 files changed, 46 insertions(+), 9 deletions(-)
> > >   create mode 100644 arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc
> > >   create mode 100644 arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/net
> > > 
> > > diff --git a/arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc b/arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc
> > > new file mode 100644
> > > index 0000000..6ad5f87
> > > --- /dev/null
> > > +++ b/arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc
> > > @@ -0,0 +1,7 @@
> > > +#!/bin/sh
> > > +
> > > +[ -e /env/config-expansions ] && /env/config-expansions
> > 
> > What do you have in these config-expansions or what do you expect to be
> > there?
> > 
> 
> These config-expanions files contain source commands for different
> expansions like HDMI, LCD, WiFi, ... and are written from Yocto. We don't
> want to bring these mainline, but without this line we have to overwrite
> each boot script file from Yocto.
> 
> Maybe this could be a good feature since we're not the only one with
> expansion configurations.

I am generally open to such expansions, I just want to understand what's
missing first.
In this case I'd like to understand why you can't add an init script to
/env/bin/init/ instead. If you want to extend the kernel commandline you
could also add a nv variable to /env/nv/linux.bootargs.yocto.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox