From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dIVaa-0004SB-8i for barebox@lists.infradead.org; Wed, 07 Jun 2017 07:41:14 +0000 Date: Wed, 7 Jun 2017 09:40:49 +0200 From: Sascha Hauer Message-ID: <20170607074049.54p75immahcjiru3@pengutronix.de> References: <20170602131808.18781-1-m.grzeschik@pengutronix.de> <20170602131808.18781-4-m.grzeschik@pengutronix.de> <20170606061840.3ygatsyaswtpqebz@pengutronix.de> <20170606110348.qogfyllbixa5wfaf@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170606110348.qogfyllbixa5wfaf@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 3/3] ARM: i.MX6: add Technexion Pico Hobbit support To: Michael Grzeschik Cc: barebox@lists.infradead.org On Tue, Jun 06, 2017 at 01:03:48PM +0200, Michael Grzeschik wrote: > On Tue, Jun 06, 2017 at 08:18:40AM +0200, Sascha Hauer wrote: > > On Fri, Jun 02, 2017 at 03:18:08PM +0200, Michael Grzeschik wrote: > > > This adds support support for the i.MX6UL Technexion Pico Hobbit. > > > The board comes with different amounts of RAM. We create one image > > > for the 256MB and one for the 512MB variant. > > > > > > Signed-off-by: Michael Grzeschik > > > --- > > > v1 -> v2: - removed already prepared clock setup > > > > > > + > > > +&usdhc1 { > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + > > > + partition@0 { > > > + label = "barebox"; > > > + reg = <0x0 0xc0000>; > > > + }; > > > + > > > + environment_usdhc1: partition@c0000 { > > > + label = "barebox-environment"; > > > + reg = <0xc0000 0x40000>; > > > + }; > > > +}; > > > + > > > +&fec2 { > > > + /* > > > + There are two possible ways to start the phy. Let the hardware > > > + reset it properly or reset it a second time in software. > > > + Unfortunetly the phy needs some microseconds after reset to > > > + settle down. As there is no property like > > > + phy-post-reset-delay, we better leave the reset to the > > > + hardware. > > > + */ > > > + /delete-property/ phy-reset-gpios; > > > + /delete-property/ phy-reset-duration; > > > > Recent Kernels support phy-reset-post-delay. Can we just add support for > > it in barebox aswell? > > Could we for now stick with this? When I write the phy-reset-post-delay > patches I will then adopt this node in the regarding series. This gives > me some time, as I can not test the post-delay patch in the next two > weeks. Ok, I reworded the comment to: /* * There are two possible ways to start the phy. Let the hardware * reset it properly or reset it a second time in software. * Unfortunetly the phy needs some microseconds after reset to * settle down. * FIXME: Port support for the "phy-reset-post-delay" property to * barebox. */ Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox