From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org, Matt Reimer <mreimer@sdgsystems.com>
Subject: Re: [PATCH] mtd: nand: omap: Fix BCH bit correction
Date: Fri, 9 Jun 2017 11:08:30 +0200 [thread overview]
Message-ID: <20170609090830.cgid2zfz2cufjqq5@pengutronix.de> (raw)
In-Reply-To: <23fe6b1a-f4af-40e0-a796-51464027b251@phytec.de>
On Fri, Jun 09, 2017 at 10:17:55AM +0200, Daniel Schultz wrote:
> Hi Sascha,
>
> > >
> > > And can not work. Additionally eccsteps must be set to 1 in
> > > omap_correct_bch(). This effectively makes the loop in this function
> > > unnecessary which can then removed.
> >
> > Which then means omap_gpmc_read_page_bch_rom_mode() has to iterate over
> > ecc.steps itself, just like the other read_page implementations in the
> > framework do.
> >
> So, the previous assignment of eccsteps was fine?
I just sent an updated patch(-series). Could you give it a try?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-06-09 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 16:10 Daniel Schultz
2017-06-07 6:45 ` Sascha Hauer
2017-06-07 6:49 ` Sascha Hauer
2017-06-07 6:53 ` Sascha Hauer
2017-06-09 8:17 ` Daniel Schultz
2017-06-09 9:08 ` Sascha Hauer [this message]
2017-06-09 13:28 ` Daniel Schultz
2017-06-12 13:41 ` Sascha Hauer
2017-06-13 11:50 ` Daniel Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609090830.cgid2zfz2cufjqq5@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=d.schultz@phytec.de \
--cc=mreimer@sdgsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox