[PATCH] serial: ns16550: emit an error message if getting the clock fails

[PATCH] serial: ns16550: emit an error message if getting the clock fails

[Uwe Kleine-König]

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/serial/serial_ns16550.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
index 439b7d5517bd..a8953cd99d62 100644
--- a/drivers/serial/serial_ns16550.c
+++ b/drivers/serial/serial_ns16550.c
@@ -445,6 +445,7 @@ static int ns16550_probe(struct device_d *dev)
 		priv->clk = clk_get(dev, NULL);
 		if (IS_ERR(priv->clk)) {
 			ret = PTR_ERR(priv->clk);
+			dev_err(dev, "failed to get clk (%d)\n", ret);
 			goto err;
 		}
 		clk_enable(priv->clk);
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] serial: ns16550: emit an error message if getting the clock fails

[Sascha Hauer]

On Wed, Jun 14, 2017 at 12:01:29AM +0200, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/serial/serial_ns16550.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 439b7d5517bd..a8953cd99d62 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -445,6 +445,7 @@ static int ns16550_probe(struct device_d *dev)
>  		priv->clk = clk_get(dev, NULL);
>  		if (IS_ERR(priv->clk)) {
>  			ret = PTR_ERR(priv->clk);
> +			dev_err(dev, "failed to get clk (%d)\n", ret);
>  			goto err;
>  		}
>  		clk_enable(priv->clk);
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox