From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: revert nvvar changes
Date: Wed, 14 Jun 2017 09:26:33 +0200 [thread overview]
Message-ID: <20170614072641.29942-1-s.hauer@pengutronix.de> (raw)
It was a bad idea to not sync nvvars to corresponding globalvars.
Doing so caused several regressions of which at least one is still
standing. Currently expanding linux bootargs with nv.linux.bootargs.*
doesn't work since the code looks for global.linux.bootargs.* which
no longer exist.
Let's revert all this stuff and forget about it. Sorry for the
inconvenience.
Sascha
----------------------------------------------------------------
Sascha Hauer (8):
Revert "globalvar: Fix value of new globalvar when nvvar exists"
Revert "nv: Fix setting of nv.dev.<devname>.<param> variables"
Revert "globalvar: make nv_device static"
Revert "globalvar: don't use nv_device if CONFIG_NVVAR is disabled"
Revert "param: remove unnecessary device_d * argument"
Revert "globalvar: make globalvar functions more consistent"
Revert "globalvar: remove code for unqualified globalvars"
Revert "nv: Do not create globalvars from nvvars"
arch/arm/boards/beaglebone/board.c | 2 +-
arch/arm/boards/crystalfontz-cfa10036/hwdetect.c | 2 +-
arch/arm/boards/phytec-som-imx6/board.c | 2 +-
arch/arm/boards/vscom-baltos/board.c | 7 +-
arch/ppc/boards/pcm030/eeprom.c | 4 +-
common/boot.c | 2 +-
common/bootchooser.c | 4 +-
common/bootm.c | 2 +-
common/console_common.c | 6 +-
common/globalvar.c | 184 +++++++++++++++--------
common/password.c | 2 +-
common/reset_source.c | 2 +-
drivers/mtd/peb.c | 6 +-
include/globalvar.h | 109 ++------------
include/param.h | 12 +-
lib/parameter.c | 44 +++---
16 files changed, 187 insertions(+), 203 deletions(-)
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2017-06-14 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 7:26 Sascha Hauer [this message]
2017-06-14 7:26 ` [PATCH 1/8] Revert "globalvar: Fix value of new globalvar when nvvar exists" Sascha Hauer
2017-06-14 7:26 ` [PATCH 2/8] Revert "nv: Fix setting of nv.dev.<devname>.<param> variables" Sascha Hauer
2017-06-14 7:26 ` [PATCH 3/8] Revert "globalvar: make nv_device static" Sascha Hauer
2017-06-14 7:26 ` [PATCH 4/8] Revert "globalvar: don't use nv_device if CONFIG_NVVAR is disabled" Sascha Hauer
2017-06-14 7:26 ` [PATCH 5/8] Revert "param: remove unnecessary device_d * argument" Sascha Hauer
2017-06-14 7:26 ` [PATCH 6/8] Revert "globalvar: make globalvar functions more consistent" Sascha Hauer
2017-06-14 7:26 ` [PATCH 7/8] Revert "globalvar: remove code for unqualified globalvars" Sascha Hauer
2017-06-14 7:26 ` [PATCH 8/8] Revert "nv: Do not create globalvars from nvvars" Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614072641.29942-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox