mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] of_device_is_stdout_path: split off options and support aliases
Date: Wed, 14 Jun 2017 15:27:32 +0200	[thread overview]
Message-ID: <20170614132732.r2fywkiouttkuur2@pengutronix.de> (raw)
In-Reply-To: <20170614113110.21604-2-u.kleine-koenig@pengutronix.de>

On Wed, Jun 14, 2017 at 01:31:10PM +0200, Uwe Kleine-König wrote:
> Several device trees use something like:
> 
> 	stdout-path = "serial0:115200n8";
> 
> Currently of_device_is_stdout_path fails to do the right thing here
> because it expects an absolute node path and no options. So split off
> options (everything after the colon) and resolve aliases.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/of/base.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 592ebb015a73..e401c11a878f 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1999,6 +1999,7 @@ int of_device_is_stdout_path(struct device_d *dev)
>  {
>  	struct device_node *dn;
>  	const char *name;
> +	char *q;
>  
>  	if (!dev->device_node)
>  		return 0;
> @@ -2010,7 +2011,16 @@ int of_device_is_stdout_path(struct device_d *dev)
>  	if (!name)
>  		return 0;
>  
> -	dn = of_find_node_by_path(name);
> +	/* This could make use of strchrnul it it were available */

s/it it/if it/

> +	q = strchr(name, ':');

This results in:

drivers/of/base.c:2017:4: warning: assignment discards 'const' qualifier from pointer target type

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-06-14 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 11:31 [PATCH 1/2] of_device_is_stdout_path: simplify Uwe Kleine-König
2017-06-14 11:31 ` [PATCH 2/2] of_device_is_stdout_path: split off options and support aliases Uwe Kleine-König
2017-06-14 13:27   ` Sascha Hauer [this message]
2017-06-14 18:02   ` [PATCH v2 " Uwe Kleine-König
2017-06-19  6:21 ` [PATCH 1/2] of_device_is_stdout_path: simplify Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614132732.r2fywkiouttkuur2@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox