* [PATCH] defaultenv: bin: init: Add sourcing of config-expansions @ 2017-06-13 13:37 Daniel Schultz 2017-06-19 7:34 ` Sascha Hauer 0 siblings, 1 reply; 5+ messages in thread From: Daniel Schultz @ 2017-06-13 13:37 UTC (permalink / raw) To: barebox This patch adds a further layer to the config hierarchy. It allows a dynamic configuration of expansions. Signed-off-by: Daniel Schultz <d.schultz@phytec.de> --- defaultenv/defaultenv-2-base/bin/init | 1 + 1 file changed, 1 insertion(+) diff --git a/defaultenv/defaultenv-2-base/bin/init b/defaultenv/defaultenv-2-base/bin/init index 7af3c7d..a93ea58 100644 --- a/defaultenv/defaultenv-2-base/bin/init +++ b/defaultenv/defaultenv-2-base/bin/init @@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the console (boolean)" [ -z "${global.editcmd}" ] && global.editcmd=sedit [ -e /env/config-board ] && /env/config-board +[ -e /env/config-expansions ] && /env/config-expansions /env/config # allow to stop the boot before execute the /env/init/* -- 1.9.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] defaultenv: bin: init: Add sourcing of config-expansions 2017-06-13 13:37 [PATCH] defaultenv: bin: init: Add sourcing of config-expansions Daniel Schultz @ 2017-06-19 7:34 ` Sascha Hauer 2017-06-20 15:50 ` Daniel Schultz 0 siblings, 1 reply; 5+ messages in thread From: Sascha Hauer @ 2017-06-19 7:34 UTC (permalink / raw) To: Daniel Schultz; +Cc: barebox On Tue, Jun 13, 2017 at 03:37:00PM +0200, Daniel Schultz wrote: > This patch adds a further layer to the config hierarchy. It allows a > dynamic configuration of expansions. > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de> > --- > defaultenv/defaultenv-2-base/bin/init | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/defaultenv/defaultenv-2-base/bin/init b/defaultenv/defaultenv-2-base/bin/init > index 7af3c7d..a93ea58 100644 > --- a/defaultenv/defaultenv-2-base/bin/init > +++ b/defaultenv/defaultenv-2-base/bin/init > @@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the console (boolean)" > [ -z "${global.editcmd}" ] && global.editcmd=sedit > > [ -e /env/config-board ] && /env/config-board > +[ -e /env/config-expansions ] && /env/config-expansions I read the last thread again and I think my question remains unanswered. Why can't you put the config-expansions to /env/init/ and let it be executed automatically without changing /bin/init? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] defaultenv: bin: init: Add sourcing of config-expansions 2017-06-19 7:34 ` Sascha Hauer @ 2017-06-20 15:50 ` Daniel Schultz 2017-06-26 6:25 ` Sascha Hauer 0 siblings, 1 reply; 5+ messages in thread From: Daniel Schultz @ 2017-06-20 15:50 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox Hi, Am 19.06.2017 um 09:34 schrieb Sascha Hauer: > On Tue, Jun 13, 2017 at 03:37:00PM +0200, Daniel Schultz wrote: >> This patch adds a further layer to the config hierarchy. It allows a >> dynamic configuration of expansions. >> >> Signed-off-by: Daniel Schultz <d.schultz@phytec.de> >> --- >> defaultenv/defaultenv-2-base/bin/init | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/defaultenv/defaultenv-2-base/bin/init b/defaultenv/defaultenv-2-base/bin/init >> index 7af3c7d..a93ea58 100644 >> --- a/defaultenv/defaultenv-2-base/bin/init >> +++ b/defaultenv/defaultenv-2-base/bin/init >> @@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the console (boolean)" >> [ -z "${global.editcmd}" ] && global.editcmd=sedit >> >> [ -e /env/config-board ] && /env/config-board >> +[ -e /env/config-expansions ] && /env/config-expansions > > I read the last thread again and I think my question remains > unanswered. Why can't you put the config-expansions to /env/init/ and > let it be executed automatically without changing /bin/init? > I can change the path of the config-expanions file without problems, but I thought there could be more who need a config for expansions. So, they have config files with a same behavior in different dirs. -- Mit freundlichen Grüßen, With best regards, Daniel Schultz _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] defaultenv: bin: init: Add sourcing of config-expansions 2017-06-20 15:50 ` Daniel Schultz @ 2017-06-26 6:25 ` Sascha Hauer 2017-06-27 9:47 ` Daniel Schultz 0 siblings, 1 reply; 5+ messages in thread From: Sascha Hauer @ 2017-06-26 6:25 UTC (permalink / raw) To: Daniel Schultz; +Cc: barebox On Tue, Jun 20, 2017 at 05:50:56PM +0200, Daniel Schultz wrote: > Hi, > > Am 19.06.2017 um 09:34 schrieb Sascha Hauer: > > On Tue, Jun 13, 2017 at 03:37:00PM +0200, Daniel Schultz wrote: > > > This patch adds a further layer to the config hierarchy. It allows a > > > dynamic configuration of expansions. > > > > > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de> > > > --- > > > defaultenv/defaultenv-2-base/bin/init | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/defaultenv/defaultenv-2-base/bin/init b/defaultenv/defaultenv-2-base/bin/init > > > index 7af3c7d..a93ea58 100644 > > > --- a/defaultenv/defaultenv-2-base/bin/init > > > +++ b/defaultenv/defaultenv-2-base/bin/init > > > @@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the console (boolean)" > > > [ -z "${global.editcmd}" ] && global.editcmd=sedit > > > [ -e /env/config-board ] && /env/config-board > > > +[ -e /env/config-expansions ] && /env/config-expansions > > > > I read the last thread again and I think my question remains > > unanswered. Why can't you put the config-expansions to /env/init/ and > > let it be executed automatically without changing /bin/init? > > > I can change the path of the config-expanions file without problems, but I > thought there could be more who need a config for expansions. So, they have > config files with a same behavior in different dirs. I think we are talking at cross-purposes. All files in /env/init/ are executed by the init script, so adding stuff that shall be executed during init to that directory would be the natural way to "expand the config". Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] defaultenv: bin: init: Add sourcing of config-expansions 2017-06-26 6:25 ` Sascha Hauer @ 2017-06-27 9:47 ` Daniel Schultz 0 siblings, 0 replies; 5+ messages in thread From: Daniel Schultz @ 2017-06-27 9:47 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox Hi, Am 26.06.2017 um 08:25 schrieb Sascha Hauer: > On Tue, Jun 20, 2017 at 05:50:56PM +0200, Daniel Schultz wrote: >> Hi, >> >> Am 19.06.2017 um 09:34 schrieb Sascha Hauer: >>> On Tue, Jun 13, 2017 at 03:37:00PM +0200, Daniel Schultz wrote: >>>> This patch adds a further layer to the config hierarchy. It allows a >>>> dynamic configuration of expansions. >>>> >>>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de> >>>> --- >>>> defaultenv/defaultenv-2-base/bin/init | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/defaultenv/defaultenv-2-base/bin/init b/defaultenv/defaultenv-2-base/bin/init >>>> index 7af3c7d..a93ea58 100644 >>>> --- a/defaultenv/defaultenv-2-base/bin/init >>>> +++ b/defaultenv/defaultenv-2-base/bin/init >>>> @@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the console (boolean)" >>>> [ -z "${global.editcmd}" ] && global.editcmd=sedit >>>> [ -e /env/config-board ] && /env/config-board >>>> +[ -e /env/config-expansions ] && /env/config-expansions >>> >>> I read the last thread again and I think my question remains >>> unanswered. Why can't you put the config-expansions to /env/init/ and >>> let it be executed automatically without changing /bin/init? >>> >> I can change the path of the config-expanions file without problems, but I >> thought there could be more who need a config for expansions. So, they have >> config files with a same behavior in different dirs. > > I think we are talking at cross-purposes. All files in /env/init/ are > executed by the init script, so adding stuff that shall be executed > during init to that directory would be the natural way to "expand the > config". > Okay, so I misunderstood you. I will add all config-expansions to /env/init, sorry! > Sascha > -- Mit freundlichen Grüßen, With best regards, Daniel Schultz _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-27 9:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-06-13 13:37 [PATCH] defaultenv: bin: init: Add sourcing of config-expansions Daniel Schultz 2017-06-19 7:34 ` Sascha Hauer 2017-06-20 15:50 ` Daniel Schultz 2017-06-26 6:25 ` Sascha Hauer 2017-06-27 9:47 ` Daniel Schultz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox