mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] defaultenv: bin: init: Add sourcing of config-expansions
Date: Mon, 26 Jun 2017 08:25:57 +0200	[thread overview]
Message-ID: <20170626062557.5kaeyculqgi3mske@pengutronix.de> (raw)
In-Reply-To: <661a7f8c-9ba8-bd25-7eb9-da77e6fb7ed4@phytec.de>

On Tue, Jun 20, 2017 at 05:50:56PM +0200, Daniel Schultz wrote:
> Hi,
> 
> Am 19.06.2017 um 09:34 schrieb Sascha Hauer:
> > On Tue, Jun 13, 2017 at 03:37:00PM +0200, Daniel Schultz wrote:
> > > This patch adds a further layer to the config hierarchy. It allows a
> > > dynamic configuration of expansions.
> > > 
> > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> > > ---
> > >   defaultenv/defaultenv-2-base/bin/init | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/defaultenv/defaultenv-2-base/bin/init b/defaultenv/defaultenv-2-base/bin/init
> > > index 7af3c7d..a93ea58 100644
> > > --- a/defaultenv/defaultenv-2-base/bin/init
> > > +++ b/defaultenv/defaultenv-2-base/bin/init
> > > @@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the console (boolean)"
> > >   [ -z "${global.editcmd}" ] && global.editcmd=sedit
> > >   [ -e /env/config-board ] && /env/config-board
> > > +[ -e /env/config-expansions ] && /env/config-expansions
> > 
> > I read the last thread again and I think my question remains
> > unanswered. Why can't you put the config-expansions to /env/init/ and
> > let it be executed automatically without changing /bin/init?
> > 
> I can change the path of the config-expanions file without problems, but I
> thought there could be more who need a config for expansions. So, they have
> config files with a same behavior in different dirs.

I think we are talking at cross-purposes. All files in /env/init/ are
executed by the init script, so adding stuff that shall be executed
during init to that directory would be the natural way to "expand the
config".

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-06-26  6:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 13:37 Daniel Schultz
2017-06-19  7:34 ` Sascha Hauer
2017-06-20 15:50   ` Daniel Schultz
2017-06-26  6:25     ` Sascha Hauer [this message]
2017-06-27  9:47       ` Daniel Schultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626062557.5kaeyculqgi3mske@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=d.schultz@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox